From: Hari Bathini <hbathini@linux.ibm.com>
To: Sourabh Jain <sourabhjain@linux.ibm.com>, linuxppc-dev@lists.ozlabs.org
Cc: Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: powerpc/fadump: skip parameter area allocation when fadump is disabled
Date: Tue, 7 Oct 2025 15:58:26 +0530 [thread overview]
Message-ID: <89ec78e5-4fe3-4100-9ae1-23f6a9f36e77@linux.ibm.com> (raw)
In-Reply-To: <20251007074023.176163-1-sourabhjain@linux.ibm.com>
On 07/10/25 1:10 pm, Sourabh Jain wrote:
> Fadump allocates memory to pass additional kernel command-line argument
> to the fadump kernel. However, this allocation is not needed when fadump
> is disabled. So avoid allocating memory for the additional parameter
> area in such cases.
>
This needs the fixes tag...
Fixes: f4892c68ecc1 ("powerpc/fadump: allocate memory for additional
parameters early")
Otherwise, looks good to me.
Reviewed-by: Hari Bathini <hbathini@linux.ibm.com>
> Cc: Hari Bathini <hbathini@linux.ibm.com>
> Cc: Madhavan Srinivasan <maddy@linux.ibm.com>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Signed-off-by: Sourabh Jain <sourabhjain@linux.ibm.com>
> ---
> arch/powerpc/kernel/fadump.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c
> index 5782e743fd27..4ebc333dd786 100644
> --- a/arch/powerpc/kernel/fadump.c
> +++ b/arch/powerpc/kernel/fadump.c
> @@ -1747,6 +1747,9 @@ void __init fadump_setup_param_area(void)
> {
> phys_addr_t range_start, range_end;
>
> + if (!fw_dump.fadump_enabled)
> + return;
> +
> if (!fw_dump.param_area_supported || fw_dump.dump_active)
> return;
>
next prev parent reply other threads:[~2025-10-07 10:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-07 7:40 powerpc/fadump: skip parameter area allocation when fadump is disabled Sourabh Jain
2025-10-07 10:28 ` Hari Bathini [this message]
2025-10-08 3:43 ` Sourabh Jain
-- strict thread matches above, loose matches on Subject: below --
2025-10-08 3:29 Sourabh Jain
2025-10-18 5:33 ` Madhavan Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89ec78e5-4fe3-4100-9ae1-23f6a9f36e77@linux.ibm.com \
--to=hbathini@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=sourabhjain@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).