From: Christophe Leroy <chleroy@kernel.org>
To: Miaoqian Lin <linmq006@gmail.com>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@ozlabs.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org
Subject: Re: [PATCH] powerpc/powermac: Fix reference count leak in i2c probe functions
Date: Fri, 14 Nov 2025 10:11:17 +0100 [thread overview]
Message-ID: <d1d857ee-60c9-4e38-82c7-062e55e6f4f3@kernel.org> (raw)
In-Reply-To: <20251027084556.80287-1-linmq006@gmail.com>
Le 27/10/2025 à 09:45, Miaoqian Lin a écrit :
> [Vous ne recevez pas souvent de courriers de linmq006@gmail.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
>
> The of_find_node_by_name() function returns a device tree node with its
> reference count incremented. The caller is responsible for calling
> of_node_put() to release this reference when done.
>
> Fixes: 730745a5c450 ("[PATCH] 1/5 powerpc: Rework PowerMac i2c part 1")
> Cc: stable@vger.kernel.org
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> arch/powerpc/platforms/powermac/low_i2c.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/powermac/low_i2c.c b/arch/powerpc/platforms/powermac/low_i2c.c
> index 02474e27df9b..f04dbb93bbfa 100644
> --- a/arch/powerpc/platforms/powermac/low_i2c.c
> +++ b/arch/powerpc/platforms/powermac/low_i2c.c
> @@ -802,8 +802,10 @@ static void __init pmu_i2c_probe(void)
> for (channel = 1; channel <= 2; channel++) {
> sz = sizeof(struct pmac_i2c_bus) + sizeof(struct adb_request);
> bus = kzalloc(sz, GFP_KERNEL);
> - if (bus == NULL)
> + if (bus == NULL) {
> + of_node_put(busnode);
We are in a loop, what happens when kzalloc() succeded in the first
iteration but not in a further iteration ? In that case we have already
registered some bus which references busnode as bus->busnode so it just
can't but put.
> return;
> + }
>
> bus->controller = busnode;
> bus->busnode = busnode;
> @@ -928,6 +930,7 @@ static void __init smu_i2c_probe(void)
> bus = kzalloc(sz, GFP_KERNEL);
> if (bus == NULL) {
> of_node_put(busnode);
> + of_node_put(controller);
> return;
> }
>
> --
> 2.39.5 (Apple Git-154)
>
--
pw-bot: cr
prev parent reply other threads:[~2025-11-14 9:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 8:45 [PATCH] powerpc/powermac: Fix reference count leak in i2c probe functions Miaoqian Lin
2025-11-14 9:11 ` Christophe Leroy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1d857ee-60c9-4e38-82c7-062e55e6f4f3@kernel.org \
--to=chleroy@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=linmq006@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulus@ozlabs.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).