From: Luis Chamberlain <mcgrof@bombadil.infradead.org>
To: jason.wessel@windriver.com, joe.lawrence@redhat.com,
daniel.thompson@linaro.org, jikos@kernel.org,
linux-modules@vger.kernel.org, llvm@lists.linux.dev,
nathan@kernel.org, trix@redhat.com, chris@chrisdown.name,
linux-kernel@vger.kernel.org, mbenes@suse.cz, terrelln@fb.com,
kgdb-bugreport@lists.sourceforge.net,
live-patching@vger.kernel.org, fmdefrancesco@gmail.com,
dianders@chromium.org, pmladek@suse.com, jpoimboe@kernel.org,
ndesaulniers@google.com, bpf@vger.kernel.org
Cc: Luis Chamberlain <mcgrof@kernel.org>,
ira.weiny@intel.com, dmitry.torokhov@gmail.com,
swboyd@chromium.org, piotrgorski@cachyos.org
Subject: Re: [PATCH] module/decompress: Never use kunmap() for local un-mappings
Date: Wed, 22 Mar 2023 16:24:33 -0700 [thread overview]
Message-ID: <167952705567.2263470.18228933182686895553.b4-ty@kernel.org> (raw)
In-Reply-To: <20230315125256.22772-1-fmdefrancesco@gmail.com>
From: Luis Chamberlain <mcgrof@kernel.org>
On Wed, 15 Mar 2023 13:52:56 +0100, Fabio M. De Francesco wrote:
> Use kunmap_local() to unmap pages locally mapped with kmap_local_page().
>
> kunmap_local() must be called on the kernel virtual address returned by
> kmap_local_page(), differently from how we use kunmap() which instead
> expects the mapped page as its argument.
>
> In module_zstd_decompress() we currently map with kmap_local_page() and
> unmap with kunmap(). This breaks the code and so it should be fixed.
>
> [...]
Applied, thanks!
[1/1] module/decompress: Never use kunmap() for local un-mappings
commit: 3c17655ab13704582fe25e8ea3200a9b2f8bf20a
Luis
prev parent reply other threads:[~2023-03-22 23:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 12:52 [PATCH] module/decompress: Never use kunmap() for local un-mappings Fabio M. De Francesco
2023-03-15 18:16 ` Ira Weiny
2023-03-17 19:04 ` Stephen Boyd
2023-03-21 8:23 ` Piotr Gorski
2023-03-21 8:33 ` Piotr Gorski
2023-03-22 23:24 ` Luis Chamberlain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167952705567.2263470.18228933182686895553.b4-ty@kernel.org \
--to=mcgrof@bombadil.infradead.org \
--cc=bpf@vger.kernel.org \
--cc=chris@chrisdown.name \
--cc=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fmdefrancesco@gmail.com \
--cc=ira.weiny@intel.com \
--cc=jason.wessel@windriver.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@kernel.org \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mbenes@suse.cz \
--cc=mcgrof@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=piotrgorski@cachyos.org \
--cc=pmladek@suse.com \
--cc=swboyd@chromium.org \
--cc=terrelln@fb.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).