From: Miroslav Benes <mbenes@suse.cz>
To: jpoimboe@redhat.com, jikos@kernel.org, pmladek@suse.com,
joe.lawrence@redhat.com
Cc: peterz@infradead.org, linux-kernel@vger.kernel.org,
live-patching@vger.kernel.org, shuah@kernel.org,
linux-kselftest@vger.kernel.org, Miroslav Benes <mbenes@suse.cz>
Subject: [PATCH v2 0/2] livepatch: Allow user to specify functions to search for on a stack
Date: Fri, 10 Dec 2021 13:44:47 +0100 [thread overview]
Message-ID: <20211210124449.21537-1-mbenes@suse.cz> (raw)
livepatch's consistency model requires that no live patched function
must be found on any task's stack during a transition process after a
live patch is applied. It is achieved by walking through stacks of all
blocked tasks.
The user might also want to define more functions to search for without
them being patched at all. It may either help with preparing a live
patch, which would otherwise require adding more functions just to
achieve the consistency, or it can be used to overcome deficiencies the
stack checking inherently has.
Consider the following example, in which GCC may optimize function
parent() so that a part of it is moved to a different section
(child.cold()) and parent() jumps to it. If both parent() and child2()
are to patching targets, things can break easily if a task sleeps in
child.cold() and new patched child2() changes ABI. parent() is not found
on the stack, child.cold() jumps back to parent() eventually and new
child2() is called.
parent(): /* to-be-patched */
...
jmp child.cold() /* cannot be patched */
...
schedule()
...
jmp <back>
...
call child2() /* to-be-patched */
...
The patch set adds a new API which allows the user to specify such
functions.
v1: https://lore.kernel.org/all/20211119090327.12811-1-mbenes@suse.cz/
Changes:
--------
v2:
- no separate klp_funcs, stack_only attribute is defined
- tests rewritten
Miroslav Benes (2):
livepatch: Allow user to specify functions to search for on a stack
selftests/livepatch: Test of the API for specifying functions to
search for on a stack
include/linux/livepatch.h | 3 +
kernel/livepatch/core.c | 28 ++-
kernel/livepatch/patch.c | 6 +
kernel/livepatch/transition.c | 5 +-
lib/livepatch/Makefile | 5 +-
lib/livepatch/test_klp_func_stack_only_demo.c | 66 ++++++++
.../test_klp_func_stack_only_demo2.c | 61 +++++++
lib/livepatch/test_klp_func_stack_only_mod.c | 70 ++++++++
tools/testing/selftests/livepatch/Makefile | 3 +-
.../livepatch/test-func-stack-only.sh | 159 ++++++++++++++++++
10 files changed, 402 insertions(+), 4 deletions(-)
create mode 100644 lib/livepatch/test_klp_func_stack_only_demo.c
create mode 100644 lib/livepatch/test_klp_func_stack_only_demo2.c
create mode 100644 lib/livepatch/test_klp_func_stack_only_mod.c
create mode 100755 tools/testing/selftests/livepatch/test-func-stack-only.sh
--
2.34.1
next reply other threads:[~2021-12-10 12:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 12:44 Miroslav Benes [this message]
2021-12-10 12:44 ` [PATCH v2 1/2] livepatch: Allow user to specify functions to search for on a stack Miroslav Benes
2021-12-13 19:00 ` Josh Poimboeuf
2021-12-14 8:47 ` Miroslav Benes
2021-12-14 12:27 ` Petr Mladek
2021-12-14 15:40 ` Petr Mladek
2021-12-14 23:48 ` Josh Poimboeuf
2021-12-15 14:37 ` Petr Mladek
2021-12-15 18:47 ` Josh Poimboeuf
2021-12-16 9:15 ` Miroslav Benes
2021-12-10 12:44 ` [PATCH v2 2/2] selftests/livepatch: Test of the API for specifying " Miroslav Benes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211210124449.21537-1-mbenes@suse.cz \
--to=mbenes@suse.cz \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).