From: Petr Mladek <pmladek@suse.com>
To: Chengming Zhou <zhouchengming@bytedance.com>
Cc: jpoimboe@redhat.com, jikos@kernel.org, mbenes@suse.cz,
joe.lawrence@redhat.com, live-patching@vger.kernel.org,
linux-kernel@vger.kernel.org, songmuchun@bytedance.com,
qirui.001@bytedance.com
Subject: Re: [PATCH v3] livepatch: Don't block removal of patches that are safe to unload
Date: Thu, 17 Mar 2022 19:38:44 +0100 [thread overview]
Message-ID: <YjOANCt6Kfnzp+HZ@alley> (raw)
In-Reply-To: <20220312152220.88127-1-zhouchengming@bytedance.com>
On Sat 2022-03-12 23:22:20, Chengming Zhou wrote:
> module_put() is not called for a patch with "forced" flag. It should
> block the removal of the livepatch module when the code might still
> be in use after forced transition.
>
> klp_force_transition() currently sets "forced" flag for all patches on
> the list.
>
> In fact, any patch can be safely unloaded when it passed through
> the consistency model in KLP_UNPATCHED transition.
>
> By other words, the "forced" flag must be set only for livepatches
> that are being removed. In particular, set the "forced" flag:
>
> + only for klp_transition_patch when the transition to KLP_UNPATCHED
> state was forced.
>
> + all replaced patches when the transition to KLP_PATCHED state was
> forced and the patch was replacing the existing patches.
>
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
The patch has been committed, with the proposed wording changes,
into livepatching/livepatching.git, branch for-5.18/fixes,
see
https://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching.git/commit/?h=for-5.18/fixes&id=2957308343fa7c621df9f342fab88cb970b8d5f3
Best Regards,
Petr
prev parent reply other threads:[~2022-03-17 18:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-12 15:22 [PATCH v3] livepatch: Don't block removal of patches that are safe to unload Chengming Zhou
2022-03-16 14:48 ` Miroslav Benes
2022-03-16 15:01 ` Petr Mladek
2022-03-16 15:03 ` Miroslav Benes
2022-03-17 1:43 ` Joe Lawrence
2022-03-17 1:15 ` [External] " Chengming Zhou
2022-03-16 14:55 ` Petr Mladek
2022-03-17 18:38 ` Petr Mladek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjOANCt6Kfnzp+HZ@alley \
--to=pmladek@suse.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=qirui.001@bytedance.com \
--cc=songmuchun@bytedance.com \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).