From: Luis Chamberlain <mcgrof@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Alessandro Carminati <alessandro.carminati@gmail.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Nicolas Schier <nicolas@fjasle.eu>,
Masami Hiramatsu <mhiramat@kernel.org>,
Daniel Bristot de Oliveira <bristot@kernel.org>,
Viktor Malik <vmalik@redhat.com>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
Nick Alcock <nick.alcock@oracle.com>,
eugene.loh@oracle.com, kris.van.hees@oracle.com,
live-patching@vger.kernel.org
Subject: Re: [PATCH v2] scripts/link-vmlinux.sh: Add alias to duplicate symbols for kallsyms
Date: Mon, 17 Jul 2023 09:50:25 -0700 [thread overview]
Message-ID: <ZLVxUQiC5iF+xTPQ@bombadil.infradead.org> (raw)
In-Reply-To: <20230717105240.3d986331@gandalf.local.home>
On Mon, Jul 17, 2023 at 10:52:40AM -0400, Steven Rostedt wrote:
> Honestly, I think the "_alias_<some-random-number>" is useless. It doesn't
> give you any clue to what function you are actually attaching to.
Agreed.
> There's
> been other approaches that show module and/or file names. I know there's
> still some issues with getting those accepted, but I much rather have them
> than this!
>
> See: https://lore.kernel.org/all/20221205163157.269335-1-nick.alcock@oracle.com/
Yes, please coordinate with Nick and review each other's work, now we
have two separate efforts with different reasons but hopefully we'll
come back with one unified solution.
Please Cc live-patching also, as they had suggested before just to
provide the file filename + line number, that'll make it even more
valuable.
Luis
next parent reply other threads:[~2023-07-17 16:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230714150326.1152359-1-alessandro.carminati@gmail.com>
[not found] ` <20230717105240.3d986331@gandalf.local.home>
2023-07-17 16:50 ` Luis Chamberlain [this message]
2023-07-18 1:01 ` [PATCH v2] scripts/link-vmlinux.sh: Add alias to duplicate symbols for kallsyms Masami Hiramatsu
2023-07-18 16:06 ` Alessandro Carminati
2023-07-18 16:55 ` Steven Rostedt
2023-07-21 9:21 ` Alessandro Carminati
2023-07-21 12:40 ` Alessandro Carminati
2023-07-24 10:30 ` Alexander Lobakin
2023-08-24 15:35 ` Francis Laniel
2023-08-25 10:15 ` Alessandro Carminati
2023-08-25 12:31 ` Masami Hiramatsu
2023-07-19 16:08 ` Masami Hiramatsu
2023-07-19 11:12 ` Nick Alcock
2023-07-19 15:12 ` Alexander Lobakin
2023-07-20 13:00 ` Nick Alcock
2023-07-20 17:00 ` Alexander Lobakin
2023-07-21 1:09 ` Masami Hiramatsu
2023-07-21 1:39 ` Kris Van Hees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLVxUQiC5iF+xTPQ@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=alessandro.carminati@gmail.com \
--cc=bristot@kernel.org \
--cc=eugene.loh@oracle.com \
--cc=kris.van.hees@oracle.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mhiramat@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nick.alcock@oracle.com \
--cc=nicolas@fjasle.eu \
--cc=rostedt@goodmis.org \
--cc=vmalik@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).