From: Jiri Kosina <jikos@kernel.org>
To: Petr Mladek <pmladek@suse.com>
Cc: Zhen Lei <thunder.leizhen@huawei.com>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Miroslav Benes <mbenes@suse.cz>,
Joe Lawrence <joe.lawrence@redhat.com>,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] livepatch: Move the result-invariant calculation out of the loop
Date: Tue, 18 Oct 2022 15:51:36 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2210181551140.29912@cbobk.fhfr.pm> (raw)
In-Reply-To: <YzacvcSOoICzYtx8@alley>
On Fri, 30 Sep 2022, Petr Mladek wrote:
> > The calculation results of the variables 'func_addr' and 'func_size' are
> > not affected by the for loop and do not change due to the changes of
> > entries[i]. The performance can be improved by moving it outside the loop.
> >
> > No functional change.
> >
> > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>
> Makes sense:
>
> Reviewed-by: Petr Mladek <pmladek@suse.com>
Seems like this wasn't picked up by anybody, so I have now pushed it to
livepatching.git#for-6.2/core
Thanks,
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2022-10-18 13:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 1:54 [PATCH] livepatch: Move the result-invariant calculation out of the loop Zhen Lei
2022-09-30 7:37 ` Petr Mladek
2022-10-18 13:51 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2210181551140.29912@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.com \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).