LKML Archive mirror
 help / color / mirror / Atom feed
* [syzbot] [ext4?] KMSAN: uninit-value in ext4_inlinedir_to_tree
@ 2024-04-29 16:05 syzbot
  2024-04-30  5:34 ` Edward Adam Davis
  0 siblings, 1 reply; 5+ messages in thread
From: syzbot @ 2024-04-29 16:05 UTC (permalink / raw
  To: adilger.kernel, linux-ext4, linux-fsdevel, linux-kernel,
	syzkaller-bugs, tytso

Hello,

syzbot found the following issue on:

HEAD commit:    e88c4cfcb7b8 Merge tag 'for-6.9-rc5-tag' of git://git.kern..
git tree:       upstream
console+strace: https://syzkaller.appspot.com/x/log.txt?x=12fbc980980000
kernel config:  https://syzkaller.appspot.com/x/.config?x=776c05250f36d55c
dashboard link: https://syzkaller.appspot.com/bug?extid=eaba5abe296837a640c0
compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=13e2cd27180000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=1741a028980000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/76771e00ba79/disk-e88c4cfc.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/c957ed943a4f/vmlinux-e88c4cfc.xz
kernel image: https://storage.googleapis.com/syzbot-assets/e719306ed8e3/bzImage-e88c4cfc.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/9d3c2a1fa449/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+eaba5abe296837a640c0@syzkaller.appspotmail.com

EXT4-fs (loop0): mounted filesystem 00000000-0000-0000-0000-000000000000 r/w without journal. Quota mode: none.
EXT4-fs warning (device loop0): __ext4fs_dirhash:270: inode #12: comm syz-executor253: Siphash requires key
=====================================================
BUG: KMSAN: uninit-value in ext4_inlinedir_to_tree+0xde2/0x15a0 fs/ext4/inline.c:1415
 ext4_inlinedir_to_tree+0xde2/0x15a0 fs/ext4/inline.c:1415
 ext4_htree_fill_tree+0x1941/0x1cd0 fs/ext4/namei.c:1210
 ext4_dx_readdir fs/ext4/dir.c:597 [inline]
 ext4_readdir+0x4bbf/0x5b00 fs/ext4/dir.c:142
 iterate_dir+0x688/0x870 fs/readdir.c:110
 __do_sys_getdents64 fs/readdir.c:409 [inline]
 __se_sys_getdents64+0x169/0x530 fs/readdir.c:394
 __x64_sys_getdents64+0x96/0xe0 fs/readdir.c:394
 x64_sys_call+0x343d/0x3b50 arch/x86/include/generated/asm/syscalls_64.h:218
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xcf/0x1e0 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f

Local variable hinfo created at:
 ext4_htree_fill_tree+0x52/0x1cd0 fs/ext4/namei.c:1185
 ext4_dx_readdir fs/ext4/dir.c:597 [inline]
 ext4_readdir+0x4bbf/0x5b00 fs/ext4/dir.c:142

CPU: 1 PID: 5020 Comm: syz-executor253 Not tainted 6.9.0-rc5-syzkaller-00042-ge88c4cfcb7b8 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024
=====================================================


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [syzbot] [ext4?] KMSAN: uninit-value in ext4_inlinedir_to_tree
  2024-04-29 16:05 syzbot
@ 2024-04-30  5:34 ` Edward Adam Davis
  2024-04-30  7:35   ` syzbot
  0 siblings, 1 reply; 5+ messages in thread
From: Edward Adam Davis @ 2024-04-30  5:34 UTC (permalink / raw
  To: syzbot+eaba5abe296837a640c0; +Cc: linux-kernel, syzkaller-bugs

please test uv in ext4_inlinedir_to_tree

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master

diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index 5e4f65c14dfb..3611952570a7 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -1182,7 +1182,7 @@ static int htree_dirblock_to_tree(struct file *dir_file,
 int ext4_htree_fill_tree(struct file *dir_file, __u32 start_hash,
 			 __u32 start_minor_hash, __u32 *next_hash)
 {
-	struct dx_hash_info hinfo;
+	struct dx_hash_info hinfo = {};
 	struct ext4_dir_entry_2 *de;
 	struct dx_frame frames[EXT4_HTREE_LEVEL], *frame;
 	struct inode *dir;


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [syzbot] [ext4?] KMSAN: uninit-value in ext4_inlinedir_to_tree
  2024-04-30  5:34 ` Edward Adam Davis
@ 2024-04-30  7:35   ` syzbot
  0 siblings, 0 replies; 5+ messages in thread
From: syzbot @ 2024-04-30  7:35 UTC (permalink / raw
  To: eadavis, linux-kernel, syzkaller-bugs

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-and-tested-by: syzbot+eaba5abe296837a640c0@syzkaller.appspotmail.com

Tested on:

commit:         98369dcc Merge tag 'wq-for-6.9-rc6-fixes' of git://git..
git tree:       https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
console output: https://syzkaller.appspot.com/x/log.txt?x=12ca42f8980000
kernel config:  https://syzkaller.appspot.com/x/.config?x=bbf567496022057b
dashboard link: https://syzkaller.appspot.com/bug?extid=eaba5abe296837a640c0
compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
patch:          https://syzkaller.appspot.com/x/patch.diff?x=100abe7f180000

Note: testing is done by a robot and is best-effort only.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [syzbot] [ext4?] KMSAN: uninit-value in ext4_inlinedir_to_tree
       [not found] <CABtBSaYXM0jR-HovWtxiX+KWhmL7M0aDwo6w488igKgkrCOyJg@mail.gmail.com>
@ 2024-04-30  8:47 ` syzbot
  0 siblings, 0 replies; 5+ messages in thread
From: syzbot @ 2024-04-30  8:47 UTC (permalink / raw
  To: linux-kernel, shenxiaxi26, syzkaller-bugs

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
no output from test machine



Tested on:

commit:         98369dcc Merge tag 'wq-for-6.9-rc6-fixes' of git://git..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=16fc9e40980000
kernel config:  https://syzkaller.appspot.com/x/.config?x=bbf567496022057b
dashboard link: https://syzkaller.appspot.com/bug?extid=eaba5abe296837a640c0
compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
patch:          https://syzkaller.appspot.com/x/patch.diff?x=1771da0f180000


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [syzbot] [ext4?] KMSAN: uninit-value in ext4_inlinedir_to_tree
       [not found] <CABtBSaZ-Qqb0ZB7CC1JMuO2pkT6YmRvibhb67x=QkOQMCdq8ow@mail.gmail.com>
@ 2024-04-30 20:09 ` syzbot
  0 siblings, 0 replies; 5+ messages in thread
From: syzbot @ 2024-04-30 20:09 UTC (permalink / raw
  To: linux-kernel, shenxiaxi26, syzkaller-bugs

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-and-tested-by: syzbot+eaba5abe296837a640c0@syzkaller.appspotmail.com

Tested on:

commit:         50dffbf7 Merge tag 'for-v6.9-rc' of git://git.kernel.o..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=1489a58b180000
kernel config:  https://syzkaller.appspot.com/x/.config?x=bbf567496022057b
dashboard link: https://syzkaller.appspot.com/bug?extid=eaba5abe296837a640c0
compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
patch:          https://syzkaller.appspot.com/x/patch.diff?x=11ac32f8980000

Note: testing is done by a robot and is best-effort only.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-04-30 20:09 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <CABtBSaZ-Qqb0ZB7CC1JMuO2pkT6YmRvibhb67x=QkOQMCdq8ow@mail.gmail.com>
2024-04-30 20:09 ` [syzbot] [ext4?] KMSAN: uninit-value in ext4_inlinedir_to_tree syzbot
     [not found] <CABtBSaYXM0jR-HovWtxiX+KWhmL7M0aDwo6w488igKgkrCOyJg@mail.gmail.com>
2024-04-30  8:47 ` syzbot
2024-04-29 16:05 syzbot
2024-04-30  5:34 ` Edward Adam Davis
2024-04-30  7:35   ` syzbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).