From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751237AbcBMG7O (ORCPT ); Sat, 13 Feb 2016 01:59:14 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:42361 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751153AbcBMG7F (ORCPT ); Sat, 13 Feb 2016 01:59:05 -0500 From: "Sricharan" To: "'Wolfram Sang'" Cc: , , , , , , , , , , , References: <1453197766-18976-1-git-send-email-sricharan@codeaurora.org> <1453197766-18976-5-git-send-email-sricharan@codeaurora.org> <20160212183737.GA1520@katana> In-Reply-To: <20160212183737.GA1520@katana> Subject: RE: [PATCH V7 4/6] i2c: qup: Add bam dma capabilities Date: Sat, 13 Feb 2016 12:28:50 +0530 Message-ID: <002e01d1662c$0579d640$106d82c0$@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 15.0 Thread-Index: AQHBrzqT1wRAKGgXA8TA5/snlKrqvgGE+T16AeSfa6WfLatGIA== Content-Language: en-us Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wolfram, > -----Original Message----- > From: Wolfram Sang [mailto:wsa@the-dreams.de] > Sent: Saturday, February 13, 2016 12:08 AM > To: Sricharan R > Cc: devicetree@vger.kernel.org; linux-arm-msm@vger.kernel.org; > agross@codeaurora.org; linux-kernel@vger.kernel.org; linux- > i2c@vger.kernel.org; iivanov@mm-sol.com; galak@codeaurora.org; > dmaengine@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > andy.gross@linaro.org; ntelkar@codeaurora.org; architt@codeaurora.org > Subject: Re: [PATCH V7 4/6] i2c: qup: Add bam dma capabilities > > On Tue, Jan 19, 2016 at 03:32:44PM +0530, Sricharan R wrote: > > QUP cores can be attached to a BAM module, which acts as a dma engine > > for the QUP core. When DMA with BAM is enabled, the BAM consumer > pipe > > transmitted data is written to the output FIFO and the BAM producer > > pipe received data is read from the input FIFO. > > > > With BAM capabilities, qup-i2c core can transfer more than > > 256 bytes, without a 'stop' which is not possible otherwise. > > > > Signed-off-by: Sricharan R > > Reviewed-by: Andy Gross > > Tested-by: Archit Taneja > > Tested-by: Telkar Nagender > > My code checkers found some issues: > > SPARSE > drivers/i2c/busses/i2c-qup.c:555:6: warning: symbol 'qup_sg_set_buf' was > not declared. Should it be static? > drivers/i2c/busses/i2c-qup.c:1243:50: warning: dubious: !x & !y > SMATCH > drivers/i2c/busses/i2c-qup.c:165 qup_sg_set_buf warn: unused return: s = > sg_next() > drivers/i2c/busses/i2c-qup.c:165 qup_sg_set_buf warn: unused return: s = > sg_next() > drivers/i2c/busses/i2c-qup.c:1243 qup_i2c_xfer_v2() warn: add some > parenthesis here? > CPPCHECK > drivers/i2c/busses/i2c-qup.c:1243: style: Boolean result is used in bitwise > operation. Clarify expression with parentheses. > SPATCH > drivers/i2c/busses/i2c-qup.c:1380:2-13: WARNING: Assignment of bool to 0/1 > drivers/i2c/busses/i2c-qup.c:1481:1-13: WARNING: Assignment of bool to 0/1 > CC drivers/i2c/busses/i2c-qup.o > drivers/i2c/busses/i2c-qup.c:555:6: warning: no previous prototype for > 'qup_sg_set_buf' [-Wmissing-prototypes] void qup_sg_set_buf(struct > scatterlist *sg, void *buf, struct qup_i2c_tag *tg, > > Can you fix them and resend?? Sorry on this , will resend this patch. Regards, Sricharan