From: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
To: "andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>
Cc: linux-power <linux-power@fi.rohmeurope.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
"michael@walle.cc" <michael@walle.cc>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>
Subject: Re: [PATCH v2 1/3] gpio: regmap: Support few IC specific operations
Date: Fri, 21 May 2021 10:20:38 +0000 [thread overview]
Message-ID: <01b1781e9ec9c474227ad914fea49db8a3a3712d.camel@fi.rohmeurope.com> (raw)
In-Reply-To: <CAHp75VcZwYdA5R=peC+8jHVT6UDsAT9msSs=W6C7rgfyjGPtXA@mail.gmail.com>
On Fri, 2021-05-21 at 13:09 +0300, Andy Shevchenko wrote:
> On Fri, May 21, 2021 at 12:53 PM Matti Vaittinen
> <matti.vaittinen@fi.rohmeurope.com> wrote:
> > The set_config and init_valid_mask GPIO operations are usually very
> > IC
> > specific. Allow IC drivers to provide these custom operations at
> > gpio-regmap registration.
>
> Thanks for this. In general (from design p.o.v.) looks good to me,
> one
> question below, though.
>
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> >
> > ---
> > Changelog v2: (based on suggestions by Michael Walle)
> > - drop gpio_regmap_set_drvdata()
>
> But why do we have gpio_regmap_get_drvdata()
I was thinking the drivers might still need to get the drvdata. But now
I don't see how they could easily get it via this API. Yes, the
regmap_gpio struct (which is used to obtain the data via this API) is
returned by the registration - but the only place where IC driver could
store this is in the drvdata :) So yes, this is next to useless now.
Sure this API could be used in probe, after the registration - but
there the driver should have access to drvdata and config anyways.
I'll drop also the gpio_regmap_get_drvdata() in next version. Thanks
for pointing this out.
> and why is it different
> now to the new member handling?
Hmm. I am unsure what you mean by this?
>
> > - drop checks and WARN() for pretty much impossible cases
next prev parent reply other threads:[~2021-05-21 10:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 6:27 [PATCH v2 0/3] gpio: gpio-regmap: Support few custom operations Matti Vaittinen
2021-05-21 6:27 ` [PATCH v2 1/3] gpio: regmap: Support few IC specific operations Matti Vaittinen
2021-05-21 8:04 ` Michael Walle
2021-05-21 10:09 ` Andy Shevchenko
2021-05-21 10:19 ` Michael Walle
2021-05-21 10:25 ` Vaittinen, Matti
2021-05-21 10:46 ` Michael Walle
2021-05-21 11:36 ` Vaittinen, Matti
2021-05-21 11:19 ` Andy Shevchenko
2021-05-21 11:41 ` Vaittinen, Matti
2021-05-21 10:20 ` Vaittinen, Matti [this message]
2021-05-21 6:28 ` [PATCH v2 2/3] gpio: gpio-regmap: Use devm_add_action() Matti Vaittinen
2021-05-21 8:10 ` Michael Walle
2021-05-21 8:38 ` Bjørn Mork
2021-05-21 10:30 ` Vaittinen, Matti
2021-05-21 16:35 ` Bartosz Golaszewski
2021-05-24 5:01 ` Vaittinen, Matti
2021-05-21 10:10 ` Andy Shevchenko
2021-05-21 6:29 ` [PATCH v2 3/3] gpio: bd71815: Use gpio-regmap Matti Vaittinen
2021-05-21 10:12 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01b1781e9ec9c474227ad914fea49db8a3a3712d.camel@fi.rohmeurope.com \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-power@fi.rohmeurope.com \
--cc=michael@walle.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).