From: Ralph Campbell <rcampbell@nvidia.com>
To: Jani Nikula <jani.nikula@intel.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/edid: Add quirk for OSVR HDK 2.0
Date: Fri, 9 Jun 2023 10:29:56 -0700 [thread overview]
Message-ID: <09cc666a-bc52-44b3-230c-26dc705c5a56@nvidia.com> (raw)
In-Reply-To: <87y1ktqa75.fsf@intel.com>
On 6/9/23 02:03, Jani Nikula wrote:
> On Thu, 08 Jun 2023, Ralph Campbell <rcampbell@nvidia.com> wrote:
>> The OSVR virtual reality headset HDK 2.0 uses a different EDID
>> vendor and device identifier than the HDK 1.1 - 1.4 headsets.
>> Add the HDK 2.0 vendor and device identifier to the quirks table so
>> that window managers do not try to display the desktop screen on the
>> headset display.
> At some point in time we requested bugs to be filed about quirks, with
> EDIDs attached, so we could look at them later, and maybe remove the
> quirks.
>
> The headset non-desktop thing started off as a quirk, but since then
> we've added both Microsoft VSDB and DisplayID primary use as ways to
> indicate this without quirks.
>
> BR,
> Jani.
If you want me to file a bug, I can do that and I have the EDID too.
Where would I file it?
I did see the DisplayID 2.0 code. This headset is no longer being
manufactured so updating the EDID is not practical.
>> Signed-off-by: Ralph Campbell <rcampbell@nvidia.com>
>> Tested-by: Ralph Campbell <rcampbell@nvidia.com>
>> ---
>> drivers/gpu/drm/drm_edid.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> I don't know how many of these VR headsets are still around but I have a
>> working one and I saw and entry for HDK 1.x so I thought it would be good
>> to add HDK 2.0.
>>
>> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
>> index 0454da505687..3b8cc1fe05e8 100644
>> --- a/drivers/gpu/drm/drm_edid.c
>> +++ b/drivers/gpu/drm/drm_edid.c
>> @@ -230,6 +230,7 @@ static const struct edid_quirk {
>>
>> /* OSVR HDK and HDK2 VR Headsets */
>> EDID_QUIRK('S', 'V', 'R', 0x1019, EDID_QUIRK_NON_DESKTOP),
>> + EDID_QUIRK('A', 'O', 'U', 0x1111, EDID_QUIRK_NON_DESKTOP),
>> };
>>
>> /*
next prev parent reply other threads:[~2023-06-09 17:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 1:42 [PATCH] drm/edid: Add quirk for OSVR HDK 2.0 Ralph Campbell
2023-06-09 9:03 ` Jani Nikula
2023-06-09 17:29 ` Ralph Campbell [this message]
2023-06-10 7:22 ` Jani Nikula
2023-06-11 6:09 ` Ralph Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09cc666a-bc52-44b3-230c-26dc705c5a56@nvidia.com \
--to=rcampbell@nvidia.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).