From: Sui Jingfeng <suijingfeng@loongson.cn>
To: Rob Herring <robh@kernel.org>,
Lucas Stach <l.stach@pengutronix.de>,
Russell King <linux+etnaviv@armlinux.org.uk>,
Christian Gmeiner <christian.gmeiner@gmail.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: etnaviv: Replace of_platform.h with explicit includes
Date: Sun, 11 Jun 2023 14:49:16 +0800 [thread overview]
Message-ID: <0ce32e34-d53b-4038-ef39-3b0f3e2f8a7f@loongson.cn> (raw)
In-Reply-To: <CAL_JsqLeAvEVa8h3qywqESkqGG1O+9QWqA7fc1EJeDGkmAV7Fw@mail.gmail.com>
Reviewed-by: Sui Jingfeng <suijingfeng@loongson.cn>
On 2023/6/10 04:17, Rob Herring wrote:
> On Mon, Apr 10, 2023 at 5:26 PM Rob Herring <robh@kernel.org> wrote:
>> Etnaviv doesn't use anything from of_platform.h, but depends on
>> of.h, of_device.h, and platform_device.h which are all implicitly
>> included, but that is going to be removed soon.
>>
>> Signed-off-by: Rob Herring <robh@kernel.org>
>> ---
>> drivers/gpu/drm/etnaviv/etnaviv_drv.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
> Ping!
of_device.h already has 'linux/of.h' and 'linux/platform_device.h' included,
Would it be sufficient by simply including linux/of_device.h ?
I'm fine with the above question explained.
```
#include <linux/platform_device.h>
#include <linux/of_platform.h> /* temporary until merge */
#include <linux/of.h>
```
>> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
>> index 44ca803237a5..c68e83ed5a23 100644
>> --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
>> +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
>> @@ -6,7 +6,9 @@
>> #include <linux/component.h>
>> #include <linux/dma-mapping.h>
>> #include <linux/module.h>
>> -#include <linux/of_platform.h>
>> +#include <linux/of.h>
>> +#include <linux/of_device.h>
>> +#include <linux/platform_device.h>
>> #include <linux/uaccess.h>
>>
>> #include <drm/drm_debugfs.h>
>> --
>> 2.39.2
>>
--
Jingfeng
next prev parent reply other threads:[~2023-06-11 7:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 23:26 [PATCH] drm: etnaviv: Replace of_platform.h with explicit includes Rob Herring
2023-06-09 20:17 ` Rob Herring
2023-06-11 6:49 ` Sui Jingfeng [this message]
2023-06-12 18:15 ` Rob Herring
2023-06-12 18:20 ` Sui Jingfeng
2023-06-21 13:20 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ce32e34-d53b-4038-ef39-3b0f3e2f8a7f@loongson.cn \
--to=suijingfeng@loongson.cn \
--cc=airlied@gmail.com \
--cc=christian.gmeiner@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=etnaviv@lists.freedesktop.org \
--cc=l.stach@pengutronix.de \
--cc=linux+etnaviv@armlinux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).