From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755140AbcBHA6P (ORCPT ); Sun, 7 Feb 2016 19:58:15 -0500 Received: from v094114.home.net.pl ([79.96.170.134]:51699 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750749AbcBHA6O (ORCPT ); Sun, 7 Feb 2016 19:58:14 -0500 From: "Rafael J. Wysocki" To: Viresh Kumar Cc: Linux PM list , Linux Kernel Mailing List , Srinivas Pandruvada , Juri Lelli , Steve Muckle , Saravana Kannan Subject: Re: [PATCH 1/3] cpufreq: governor: Simplify cpufreq_governor_limits() Date: Mon, 08 Feb 2016 01:59:23 +0100 Message-ID: <10187078.AMqBgvu9OI@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.5.0-rc1+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160207154024.GF3808@vireshk> References: <3705929.bslqXH980s@vostro.rjw.lan> <1465939.LaiBibfCQO@vostro.rjw.lan> <20160207154024.GF3808@vireshk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, February 07, 2016 09:10:24 PM Viresh Kumar wrote: > On 07-02-16, 16:23, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > Use the observation that cpufreq_governor_limits() doesn't have to > > get to the policy object it wants to manipulate by walking the > > reference chain cdbs->policy_dbs->policy, as the final pointer is > > actually equal to its argument, and make it access the policy > > object directy via its argument. > > > > Signed-off-by: Rafael J. Wysocki > > --- > > drivers/cpufreq/cpufreq_governor.c | 17 ++++++++--------- > > 1 file changed, 8 insertions(+), 9 deletions(-) > > Why the hell did we write it that way earlier ? :) Honestly, I have no idea. > Acked-by: Viresh Kumar Thanks!