From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67553EB64D8 for ; Tue, 20 Jun 2023 18:57:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230229AbjFTS5n (ORCPT ); Tue, 20 Jun 2023 14:57:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230202AbjFTS5i (ORCPT ); Tue, 20 Jun 2023 14:57:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC43610F8; Tue, 20 Jun 2023 11:57:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 892DD6142A; Tue, 20 Jun 2023 18:57:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E548AC433C8; Tue, 20 Jun 2023 18:57:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687287457; bh=dc2iLR5pVFmqyz7wtfc1R3P35ih9tEb3qrjZLB7V6x4=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=OwPpRHmgDqXrrDNknPlR0JVnQIkbyjwhZzt7bfeHy2jjcNVTB/g/dyCSgAfm12KPG HHeZAd7ocXBr3sMv8ephQ5U5/a1rMVMpCehCXB/x0ojtb4hEdg43JZhZZe8F7SLxQO 8MyOS0DLSCUCOM8gHD3ppcIe8bIiQrMd89n1eoclocnEc2YwbfAARt0sDDLlcH3uwh tR+0a+Vx1SLIdYlfkXyYDKseLLAngvHIIxkFlBLHKpRRGiWqFHx4Y4AG62UWs9k51o 2cjqU+2GlMWSA1iJ/3CUGYWfAAfi6sqgG/xDSdbmQNGMf/g+V9nA+kAoNEULAI7MPp 1Zfwhm2/U2PDA== Message-ID: <101e859b5ef84b911b87ec87b9829dea.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230327-mvebu-clk-fixes-v2-2-8333729ee45d@kernel.org> References: <20230327-mvebu-clk-fixes-v2-0-8333729ee45d@kernel.org> <20230327-mvebu-clk-fixes-v2-2-8333729ee45d@kernel.org> Subject: Re: [PATCH v2 2/4] clk: mvebu: Use of_get_cpu_hwid() to read CPU ID From: Stephen Boyd Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org To: Andrew Lunn , Gregory Clement , Michael Turquette , Rob Herring , Sebastian Hesselbarth Date: Tue, 20 Jun 2023 11:57:34 -0700 User-Agent: alot/0.10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Rob Herring (2023-06-09 11:13:46) > Use of_get_cpu_hwid() rather than the open coded reading of the CPU > nodes "reg" property. The existing code is in fact wrong as the "reg" > address cells size is 2 cells for arm64. The existing code happens to > work because the DTS files are wrong as well. >=20 > Signed-off-by: Rob Herring > --- Applied to clk-next