* [PATCH 1/1 linux-next] net: fs_enet: use swap() in fs_enet_rx_napi()
@ 2015-06-10 16:33 Fabian Frederick
2015-06-11 22:21 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2015-06-10 16:33 UTC (permalink / raw
To: linux-kernel
Cc: Julia Lawall, Fabian Frederick, Pantelis Antoniou, Vitaly Bordug,
linuxppc-dev, netdev
Use kernel.h macro definition.
Thanks to Julia Lawall for Coccinelle scripting support.
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
index 9b3639e..c5f299d 100644
--- a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
+++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
@@ -86,7 +86,7 @@ static int fs_enet_rx_napi(struct napi_struct *napi, int budget)
struct net_device *dev = fep->ndev;
const struct fs_platform_info *fpi = fep->fpi;
cbd_t __iomem *bdp;
- struct sk_buff *skb, *skbn, *skbt;
+ struct sk_buff *skb, *skbn;
int received = 0;
u16 pkt_len, sc;
int curidx;
@@ -161,10 +161,7 @@ static int fs_enet_rx_napi(struct napi_struct *napi, int budget)
skb_reserve(skbn, 2); /* align IP header */
skb_copy_from_linear_data(skb,
skbn->data, pkt_len);
- /* swap */
- skbt = skb;
- skb = skbn;
- skbn = skbt;
+ swap(skb, skbn);
}
} else {
skbn = netdev_alloc_skb(dev, ENET_RX_FRSIZE);
--
2.4.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1 linux-next] net: fs_enet: use swap() in fs_enet_rx_napi()
2015-06-10 16:33 [PATCH 1/1 linux-next] net: fs_enet: use swap() in fs_enet_rx_napi() Fabian Frederick
@ 2015-06-11 22:21 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-06-11 22:21 UTC (permalink / raw
To: fabf
Cc: linux-kernel, Julia.Lawall, pantelis.antoniou, vbordug,
linuxppc-dev, netdev
From: Fabian Frederick <fabf@skynet.be>
Date: Wed, 10 Jun 2015 18:33:19 +0200
> Use kernel.h macro definition.
>
> Thanks to Julia Lawall for Coccinelle scripting support.
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-11 22:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-10 16:33 [PATCH 1/1 linux-next] net: fs_enet: use swap() in fs_enet_rx_napi() Fabian Frederick
2015-06-11 22:21 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).