* [PATCH] regulator: qcom_spmi-regulator: Use DIV_ROUND_UP instead of open-coded
@ 2015-07-09 8:48 Axel Lin
2015-07-09 17:15 ` Andy Gross
2015-07-10 0:25 ` Applied "regulator: qcom_spmi-regulator: Use DIV_ROUND_UP instead of open-coded" to the regulator tree Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2015-07-09 8:48 UTC (permalink / raw
To: Mark Brown
Cc: Stephen Boyd, Liam Girdwood, linux-kernel@vger.kernel.org,
Andy Gross
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/qcom_spmi-regulator.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/regulator/qcom_spmi-regulator.c b/drivers/regulator/qcom_spmi-regulator.c
index 850a30a..9ef0e2f 100644
--- a/drivers/regulator/qcom_spmi-regulator.c
+++ b/drivers/regulator/qcom_spmi-regulator.c
@@ -504,8 +504,7 @@ static int spmi_regulator_select_voltage(struct spmi_regulator *vreg,
* Force uV to be an allowed set point by applying a ceiling function to
* the uV value.
*/
- *voltage_sel = (uV - range->min_uV + range->step_uV - 1)
- / range->step_uV;
+ *voltage_sel = DIV_ROUND_UP(uV - range->min_uV, range->step_uV);
uV = *voltage_sel * range->step_uV + range->min_uV;
if (uV > max_uV) {
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: qcom_spmi-regulator: Use DIV_ROUND_UP instead of open-coded
2015-07-09 8:48 [PATCH] regulator: qcom_spmi-regulator: Use DIV_ROUND_UP instead of open-coded Axel Lin
@ 2015-07-09 17:15 ` Andy Gross
2015-07-10 0:25 ` Applied "regulator: qcom_spmi-regulator: Use DIV_ROUND_UP instead of open-coded" to the regulator tree Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Andy Gross @ 2015-07-09 17:15 UTC (permalink / raw
To: Axel Lin
Cc: Mark Brown, Stephen Boyd, Liam Girdwood,
linux-kernel@vger.kernel.org
On Thu, Jul 09, 2015 at 04:48:50PM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/regulator/qcom_spmi-regulator.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Andy Gross <agross@codeaurora.org>
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread
* Applied "regulator: qcom_spmi-regulator: Use DIV_ROUND_UP instead of open-coded" to the regulator tree
2015-07-09 8:48 [PATCH] regulator: qcom_spmi-regulator: Use DIV_ROUND_UP instead of open-coded Axel Lin
2015-07-09 17:15 ` Andy Gross
@ 2015-07-10 0:25 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2015-07-10 0:25 UTC (permalink / raw
To: Axel Lin, Mark Brown; +Cc: linux-kernel
The patch
regulator: qcom_spmi-regulator: Use DIV_ROUND_UP instead of open-coded
has been applied to the regulator tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 5d506a5ad4155e813d254d2f02ce17b58045423c Mon Sep 17 00:00:00 2001
From: Axel Lin <axel.lin@ingics.com>
Date: Thu, 9 Jul 2015 16:48:50 +0800
Subject: [PATCH] regulator: qcom_spmi-regulator: Use DIV_ROUND_UP instead of
open-coded
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Reviewed-by: Andy Gross <agross@codeaurora.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/regulator/qcom_spmi-regulator.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/regulator/qcom_spmi-regulator.c b/drivers/regulator/qcom_spmi-regulator.c
index 850a30a95b5b..9ef0e2f28ec4 100644
--- a/drivers/regulator/qcom_spmi-regulator.c
+++ b/drivers/regulator/qcom_spmi-regulator.c
@@ -504,8 +504,7 @@ static int spmi_regulator_select_voltage(struct spmi_regulator *vreg,
* Force uV to be an allowed set point by applying a ceiling function to
* the uV value.
*/
- *voltage_sel = (uV - range->min_uV + range->step_uV - 1)
- / range->step_uV;
+ *voltage_sel = DIV_ROUND_UP(uV - range->min_uV, range->step_uV);
uV = *voltage_sel * range->step_uV + range->min_uV;
if (uV > max_uV) {
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-10 0:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-09 8:48 [PATCH] regulator: qcom_spmi-regulator: Use DIV_ROUND_UP instead of open-coded Axel Lin
2015-07-09 17:15 ` Andy Gross
2015-07-10 0:25 ` Applied "regulator: qcom_spmi-regulator: Use DIV_ROUND_UP instead of open-coded" to the regulator tree Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).