LKML Archive mirror
 help / color / mirror / Atom feed
* [PATCH 4/4] hw_random: brcm63xx-rng: document device tree bindings
@ 2016-01-17  9:03 Álvaro Fernández Rojas
  2016-01-18 19:11 ` Florian Fainelli
  2016-01-20 17:20 ` Rob Herring
  0 siblings, 2 replies; 3+ messages in thread
From: Álvaro Fernández Rojas @ 2016-01-17  9:03 UTC (permalink / raw
  To: linux-crypto, herbert, linux-kernel, devicetree, f.fainelli, jogo,
	cernekee
  Cc: Álvaro Fernández Rojas

Documents device tree bindings for random number generator present on Broadcom
BCM6368 SoC.

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
---
 Documentation/devicetree/bindings/rng/brcm,bcm6368.txt | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/rng/brcm,bcm6368.txt

diff --git a/Documentation/devicetree/bindings/rng/brcm,bcm6368.txt b/Documentation/devicetree/bindings/rng/brcm,bcm6368.txt
new file mode 100644
index 0000000..4b5ac60
--- /dev/null
+++ b/Documentation/devicetree/bindings/rng/brcm,bcm6368.txt
@@ -0,0 +1,17 @@
+BCM6368 Random number generator
+
+Required properties:
+
+- compatible : should be "brcm,bcm6368-rng"
+- reg : Specifies base physical address and size of the registers
+- clocks : phandle to clock-controller plus clock-specifier pair
+- clock-names : "ipsec" as a clock name
+
+Example:
+	random: rng@10004180 {
+		compatible = "brcm,bcm6368-rng";
+		reg = <0x10004180 0x14>;
+
+		clocks = <&periph_clk 18>;
+		clock-names = "ipsec";
+	};
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 4/4] hw_random: brcm63xx-rng: document device tree bindings
  2016-01-17  9:03 [PATCH 4/4] hw_random: brcm63xx-rng: document device tree bindings Álvaro Fernández Rojas
@ 2016-01-18 19:11 ` Florian Fainelli
  2016-01-20 17:20 ` Rob Herring
  1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2016-01-18 19:11 UTC (permalink / raw
  To: Álvaro Fernández Rojas, linux-crypto, herbert,
	linux-kernel, devicetree, jogo, cernekee

Le 17/01/2016 01:03, Álvaro Fernández Rojas a écrit :
> Documents device tree bindings for random number generator present on Broadcom
> BCM6368 SoC.
> 
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

I could not track down the proper versioning of this IP block, so this
is a good choice, thanks!

Nit: it is kind of nice to re-order the binding addition to come before
the driver and/or driver conversion to Device Tree probing.
-- 
Florian

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 4/4] hw_random: brcm63xx-rng: document device tree bindings
  2016-01-17  9:03 [PATCH 4/4] hw_random: brcm63xx-rng: document device tree bindings Álvaro Fernández Rojas
  2016-01-18 19:11 ` Florian Fainelli
@ 2016-01-20 17:20 ` Rob Herring
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2016-01-20 17:20 UTC (permalink / raw
  To: Álvaro Fernández Rojas
  Cc: linux-crypto, herbert, linux-kernel, devicetree, f.fainelli, jogo,
	cernekee

On Sun, Jan 17, 2016 at 10:03:57AM +0100, Álvaro Fernández Rojas wrote:
> Documents device tree bindings for random number generator present on Broadcom
> BCM6368 SoC.
> 
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> ---
>  Documentation/devicetree/bindings/rng/brcm,bcm6368.txt | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/rng/brcm,bcm6368.txt

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-01-20 17:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-17  9:03 [PATCH 4/4] hw_random: brcm63xx-rng: document device tree bindings Álvaro Fernández Rojas
2016-01-18 19:11 ` Florian Fainelli
2016-01-20 17:20 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).