From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753499AbcARGim (ORCPT ); Mon, 18 Jan 2016 01:38:42 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:58003 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752600AbcARGii (ORCPT ); Mon, 18 Jan 2016 01:38:38 -0500 X-AuditID: cbfee691-f79766d0000012b6-3c-569c886cd83b From: Maninder Singh To: davem@davemloft.net, willemb@google.com, daniel@iogearbox.net, edumazet@google.com, eyal.birger@gmail.com, tklauser@distanz.ch, fruggeri@aristanetworks.com, dwmw2@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: pankaj.m@samsung.com, gh007.kim@samsung.com, hakbong5.lee@samsung.com, Maninder Singh , Vaneet Narang Subject: [PATCH] af_packet: Raw socket destruction warning fix Date: Mon, 18 Jan 2016 12:07:48 +0530 Message-id: <1453099068-39022-1-git-send-email-maninder1.s@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrJLMWRmVeSWpSXmKPExsWyRsSkWjenY06YQUeXmsXihd+YLeacb2Gx mLhyMrPF02OP2C1OuVg0737HaLHroJ1F29ufbBaXd81hszg8v43F4tgCMYt7b7YyWRw48JfR 4tDJuYwW77YcYXfg9zh26Aabx5aVN5k8rpw6ze6xc9Zddo8Fm0o9Nq/Q8ui6cYnZo2/LKkaP z5vkAjijuGxSUnMyy1KL9O0SuDKe/1/AXNDFUdFyvJm1gfEHWxcjJ4eEgInEh0072SFsMYkL 99YDxbk4hARWMEpsW/yCBaaoY8cqFojELEaJOz+3Qjk/GSVm/jwENopNQE9i1a49YAkRgQ+M Eo8ffQabyywwm1Fi588IEFtYwE7iS9dHVhCbRUBV4vX8+0xdjBwcvALuEqc/8YOYEgIKEnMm 2YCMkRC4xi6xet0WRohyAYlvkw+xQNTISmw6wAxxnKTEwRU3WCYwCi5gZFjFKJpakFxQnJRe ZKpXnJhbXJqXrpecn7uJERgjp/89m7iD8f4B60OMAhyMSjy8DmdnhwmxJpYVV+YeYjQF2jCR WUo0OR8YiXkl8YbGZkYWpiamxkbmlmZK4rw60j+DhQTSE0tSs1NTC1KL4otKc1KLDzEycXBK NTCyv3VOXpgYuCP8m/CN8H+vUhdu/unvyfJQvM3Fb5djsOT2jqyw3YqBznEJc9JnreQUaJ6p bGhYs6TNRVrIN/jK1cVfGN9f82Nqn3nX2YL9Sft7u8cFmy/+aJpVfqArxbR++ZPkwmmZ0pv/ x3+6YzH5ldqaY88KN7xssb52nUkjNk+Ccafwex8lluKMREMt5qLiRADjGghajAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGIsWRmVeSWpSXmKPExsVy+t9jQd2cjjlhBi29MhaLF35jtphzvoXF YuLKycwWT489Yrc45WLRvPsdo8Wug3YWbW9/sllc3jWHzeLw/DYWi2MLxCzuvdnKZHHgwF9G i0Mn5zJavNtyhN2B3+PYoRtsHltW3mTyuHLqNLvHzll32T0WbCr12LxCy6PrxiVmj74tqxg9 Pm+SC+CMamC0yUhNTEktUkjNS85PycxLt1XyDo53jjc1MzDUNbS0MFdSyEvMTbVVcvEJ0HXL zAG6XkmhLDGnFCgUkFhcrKRvh2lCaIibrgVMY4Sub0gQXI+RARpIWMOY8fz/AuaCLo6KluPN rA2MP9i6GDk5JARMJDp2rGKBsMUkLtxbDxTn4hASmMUocefnVhYI5yejxMyfh8A62AT0JFbt 2gOWEBH4wCjx+NFndpAEs8BsRomdPyNAbGEBO4kvXR9ZQWwWAVWJ1/PvM3UxcnDwCrhLnP7E D2JKCChIzJlkM4GRewEjwypGidSC5ILipPRco7zUcr3ixNzi0rx0veT83E2M4Dh8Jr2D8fAu 90OMAhyMSjy8DmdnhwmxJpYVV+YeYpTgYFYS4ZVOmRMmxJuSWFmVWpQfX1Sak1p8iNEUaP1E ZinR5HxgisgriTc0NjE3NTa1NLEwMbNUEufddykyTEggPbEkNTs1tSC1CKaPiYNTqoGRIegr U/DN6c1xd+wFVy3o/zrrweEdn1hm5PF0e5jeVDqqtXnh+hdrjjT3Tr/K6rNx0/uT8+96Fdeo GBduSWPe87r2xKaOc9/XfM4/VF+159REhXlMhk52/XqZppsfJU5TfnHlkLDQzoUsn2pzX0+V Efjzji/mpXMpa0ebmc/6H0G/DvMXlHH+VmIpzkg01GIuKk4EAOGvpEjZAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Receieve queue is not purged when socket dectruction is called results in kernel warning because of non zero sk_rmem_alloc. WARNING: at net/packet/af_packet.c:1142 packet_sock_destruct Backtrace: WARN_ON(atomic_read(&sk->sk_rmem_alloc) packet_sock_destruct __sk_free sock_wfree skb_release_head_state skb_release_all __kfree_skb net_tx_action __do_softirq run_ksoftirqd Signed-off-by: Vaneet Narang Signed-off-by: Maninder Singh --- net/packet/af_packet.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index 81b4b81..bcb37ba 100644 --- a/net/packet/af_packet.c +++ b/net/packet/af_packet.c @@ -1310,6 +1310,7 @@ static bool packet_rcv_has_room(struct packet_sock *po, struct sk_buff *skb) static void packet_sock_destruct(struct sock *sk) { + skb_queue_purge(&sk->sk_receive_queue); skb_queue_purge(&sk->sk_error_queue); WARN_ON(atomic_read(&sk->sk_rmem_alloc)); -- 1.7.9.5