From: tiffany lin <tiffany.lin@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: <daniel.thompson@linaro.org>, Rob Herring <robh+dt@kernel.org>,
"Hans Verkuil" <hans.verkuil@cisco.com>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Mark Rutland <mark.rutland@arm.com>,
"Daniel Kurtz" <djkurtz@chromium.org>, <eddie.huang@mediatek.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-media@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v3 4/8] dt-bindings: Add a binding for Mediatek Video Encoder
Date: Tue, 19 Jan 2016 16:03:36 +0800 [thread overview]
Message-ID: <1453190616.1088.1.camel@mtksdaap41> (raw)
In-Reply-To: <569CB321.10206@gmail.com>
Hi Matthias,
On Mon, 2016-01-18 at 10:40 +0100, Matthias Brugger wrote:
>
> On 04/01/16 11:11, Tiffany Lin wrote:
> > Add a DT binding documentation of Video Encoder for the
> > MT8173 SoC from Mediatek.
> >
> > Signed-off-by: Tiffany Lin <tiffany.lin@mediatek.com>
> > ---
> > .../devicetree/bindings/media/mediatek-vcodec.txt | 58 ++++++++++++++++++++
> > 1 file changed, 58 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/media/mediatek-vcodec.txt
> >
> > diff --git a/Documentation/devicetree/bindings/media/mediatek-vcodec.txt b/Documentation/devicetree/bindings/media/mediatek-vcodec.txt
> > new file mode 100644
> > index 0000000..5cc35ae
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/mediatek-vcodec.txt
> > @@ -0,0 +1,58 @@
> > +Mediatek Video Codec
> > +
> > +Mediatek Video Codec is the video codec hw present in Mediatek SoCs which
> > +supports high resolution encoding functionalities.
> > +
> > +Required properties:
> > +- compatible : "mediatek,mt8173-vcodec-enc" for encoder
> > +- reg : Physical base address of the video codec registers and length of
> > + memory mapped region.
> > +- interrupts : interrupt number to the cpu.
> > +- mediatek,larb : must contain the local arbiters in the current Socs.
> > +- clocks : list of clock specifiers, corresponding to entries in
> > + the clock-names property;
> > +- clock-names: must contain "vencpll", "venc_lt_sel", "vcodecpll_370p5_ck"
> > +- iommus : list of iommus specifiers should be enabled for hw encode.
> > + There are 2 cells needed to enable/disable iommu.
> > + The first one is local arbiter index(larbid), and the other is port
> > + index(portid) within local arbiter. Specifies the larbid and portid
> > + as defined in dt-binding/memory/mt8173-larb-port.h.
>
> iommus have only one cell, as in the example below. Please fix the
> binding description accordingly.
>
I will fix this in next version.
best regards,
Tiffany
> Regards,
> Matthias
>
> > +- mediatek,vpu : the node of video processor unit
> > +
> > +Example:
> > +vcodec_enc: vcodec@0x18002000 {
> > + compatible = "mediatek,mt8173-vcodec-enc";
> > + reg = <0 0x18002000 0 0x1000>, /*VENC_SYS*/
> > + <0 0x19002000 0 0x1000>; /*VENC_LT_SYS*/
> > + interrupts = <GIC_SPI 198 IRQ_TYPE_LEVEL_LOW>,
> > + <GIC_SPI 202 IRQ_TYPE_LEVEL_LOW>;
> > + mediatek,larb = <&larb3>,
> > + <&larb5>;
> > + iommus = <&iommu M4U_PORT_VENC_RCPU>,
> > + <&iommu M4U_PORT_VENC_REC>,
> > + <&iommu M4U_PORT_VENC_BSDMA>,
> > + <&iommu M4U_PORT_VENC_SV_COMV>,
> > + <&iommu M4U_PORT_VENC_RD_COMV>,
> > + <&iommu M4U_PORT_VENC_CUR_LUMA>,
> > + <&iommu M4U_PORT_VENC_CUR_CHROMA>,
> > + <&iommu M4U_PORT_VENC_REF_LUMA>,
> > + <&iommu M4U_PORT_VENC_REF_CHROMA>,
> > + <&iommu M4U_PORT_VENC_NBM_RDMA>,
> > + <&iommu M4U_PORT_VENC_NBM_WDMA>,
> > + <&iommu M4U_PORT_VENC_RCPU_SET2>,
> > + <&iommu M4U_PORT_VENC_REC_FRM_SET2>,
> > + <&iommu M4U_PORT_VENC_BSDMA_SET2>,
> > + <&iommu M4U_PORT_VENC_SV_COMA_SET2>,
> > + <&iommu M4U_PORT_VENC_RD_COMA_SET2>,
> > + <&iommu M4U_PORT_VENC_CUR_LUMA_SET2>,
> > + <&iommu M4U_PORT_VENC_CUR_CHROMA_SET2>,
> > + <&iommu M4U_PORT_VENC_REF_LUMA_SET2>,
> > + <&iommu M4U_PORT_VENC_REC_CHROMA_SET2>;
> > + mediatek,vpu = <&vpu>;
> > + clocks = <&apmixedsys CLK_APMIXED_VENCPLL>,
> > + <&topckgen CLK_TOP_VENC_LT_SEL>,
> > + <&topckgen CLK_TOP_VCODECPLL_370P5>;
> > + clock-names = "vencpll",
> > + "venc_lt_sel",
> > + "vcodecpll_370p5_ck";
> > + };
> >
next prev parent reply other threads:[~2016-01-19 8:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 10:11 [PATCH v3 0/8] Add MT8173 Video Encoder Driver and VPU Driver Tiffany Lin
2016-01-04 10:11 ` [PATCH v3 1/8] dt-bindings: Add a binding for Mediatek Video Processor Tiffany Lin
2016-01-04 14:15 ` Rob Herring
2016-01-05 3:07 ` tiffany lin
2016-02-04 11:49 ` tiffany lin
2016-02-04 18:04 ` Rob Herring
2016-02-05 1:44 ` tiffany lin
2016-01-04 10:11 ` [PATCH v3 2/8] media: VPU: mediatek: support Mediatek VPU Tiffany Lin
2016-01-04 10:11 ` [PATCH v3 3/8] arm64: dts: mediatek: Add node for Mediatek Video Processor Unit Tiffany Lin
2016-01-04 10:11 ` [PATCH v3 4/8] dt-bindings: Add a binding for Mediatek Video Encoder Tiffany Lin
2016-01-18 9:40 ` Matthias Brugger
2016-01-19 8:03 ` tiffany lin [this message]
2016-01-04 10:11 ` [PATCH v3 5/8] media: vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver Tiffany Lin
2016-01-04 10:11 ` [PATCH v3 6/8] media: vcodec: mediatek: Add Mediatek VP8 " Tiffany Lin
2016-01-04 10:11 ` [PATCH v3 7/8] media: vcodec: mediatek: Add Mediatek H264 " Tiffany Lin
2016-01-04 10:11 ` [PATCH v3 8/8] arm64: dts: mediatek: Add Video Encoder for MT8173 Tiffany Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453190616.1088.1.camel@mtksdaap41 \
--to=tiffany.lin@mediatek.com \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=djkurtz@chromium.org \
--cc=eddie.huang@mediatek.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@osg.samsung.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).