From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756158AbcA2NXh (ORCPT ); Fri, 29 Jan 2016 08:23:37 -0500 Received: from mail.bmw-carit.de ([62.245.222.98]:46562 "EHLO linuxmail.bmw-carit.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752551AbcA2NXf (ORCPT ); Fri, 29 Jan 2016 08:23:35 -0500 From: Daniel Wagner To: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Cc: Maik Broemme , Daniel Wagner Subject: [PATCH] video: Use bool instead int pointer for get_opt_bool() argument Date: Fri, 29 Jan 2016 14:23:25 +0100 Message-Id: <1454073805-14443-1-git-send-email-daniel.wagner@bmw-carit.de> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1453992270-4688-1-git-send-email-daniel.wagner@bmw-carit.de> References: <1453992270-4688-1-git-send-email-daniel.wagner@bmw-carit.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As the function name already indicates that get_opt_bool() parses for a bool. It is not a surprise that compiler is complaining about it when -Werror=incompatible-pointer-types is used: drivers/video/fbdev/intelfb/intelfbdrv.c: In function ‘intelfb_setup’: drivers/video/fbdev/intelfb/intelfbdrv.c:353:39: error: passing argument 3 of ‘get_opt_bool’ from incompatible pointer type [-Werror=incompatible-pointer-types] if (get_opt_bool(this_opt, "accel", &accel)) Signed-off-by: Daniel Wagner Reported-by: Fengguang Wu --- Hi, In the 'simple wait queue support' series is a patch which turns on -Werror=incompatible-pointer-types which will result in a compile error for intelfb. https://lkml.org/lkml/2016/1/28/462 Even if that patch wont make it, this one makes sense (at least for me :)) I'll prepend this patch to the next version of the series in order to see if I got rid of all incompatible pointer types errors caught by the kbuild test robot. cheers, daniel drivers/video/fbdev/intelfb/intelfbdrv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/intelfb/intelfbdrv.c b/drivers/video/fbdev/intelfb/intelfbdrv.c index bbec737..bf20744 100644 --- a/drivers/video/fbdev/intelfb/intelfbdrv.c +++ b/drivers/video/fbdev/intelfb/intelfbdrv.c @@ -302,7 +302,7 @@ static __inline__ int get_opt_int(const char *this_opt, const char *name, } static __inline__ int get_opt_bool(const char *this_opt, const char *name, - int *ret) + bool *ret) { if (!ret) return 0; -- 2.5.0