From: Michael Kelley <mikelley@microsoft.com>
To: will@kernel.org, catalin.marinas@arm.com, mark.rutland@arm.com,
lorenzo.pieralisi@arm.com, sudeep.holla@arm.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org,
linux-efi@vger.kernel.org, arnd@arndb.de, wei.liu@kernel.org,
ardb@kernel.org, daniel.lezcano@linaro.org, kys@microsoft.com
Cc: mikelley@microsoft.com
Subject: [PATCH v9 1/7] smccc: Add HVC call variant with result registers other than 0 thru 3
Date: Mon, 8 Mar 2021 11:57:13 -0800 [thread overview]
Message-ID: <1615233439-23346-2-git-send-email-mikelley@microsoft.com> (raw)
In-Reply-To: <1615233439-23346-1-git-send-email-mikelley@microsoft.com>
Hypercalls to Hyper-V on ARM64 may return results in registers other
than X0 thru X3, as permitted by the SMCCC spec version 1.2 and later.
Accommodate this by adding a variant of arm_smccc_1_1_hvc that allows
the caller to specify which 3 registers are returned in addition to X0.
Signed-off-by: Michael Kelley <mikelley@microsoft.com>
---
There are several ways to support returning results from registers
other than X0 thru X3, and Hyper-V usage should be compatible with
whatever the maintainers prefer. What's implemented in this patch
may be the most flexible, but it has the downside of not being a
true function interface in that args 0 thru 2 must be fixed strings,
and not general "C" expressions.
Other alternatives include:
* Create a variant that hard codes to return X5 thru X7, though
in the future there may be Hyper-V hypercalls that need a
different hard-coded variant.
* Return all of X0 thru X7 in a larger result structure. That
approach may execute more memory stores, but performance is unlikely
to be an issue for the Hyper-V hypercalls that would use it.
However, it's possible in the future that Hyper-V results might
be beyond X7, as allowed by the SMCCC v1.3 spec.
* The macro __arm_smccc_1_1() could be cloned in Hyper-V specific
code and modified to meet Hyper-V specific needs, but this seems
undesirable since Hyper-V is operating within the v1.2 spec.
In any of these cases, the call might be renamed from "_1_1_" to
"_1_2_" to reflect conformance to the later spec version.
include/linux/arm-smccc.h | 29 +++++++++++++++++++++++------
1 file changed, 23 insertions(+), 6 deletions(-)
diff --git a/include/linux/arm-smccc.h b/include/linux/arm-smccc.h
index f860645..acda958 100644
--- a/include/linux/arm-smccc.h
+++ b/include/linux/arm-smccc.h
@@ -300,12 +300,12 @@ asmlinkage void __arm_smccc_hvc(unsigned long a0, unsigned long a1,
* entitled to optimise the whole sequence away. "volatile" is what
* makes it stick.
*/
-#define __arm_smccc_1_1(inst, ...) \
+#define __arm_smccc_1_1(inst, reg1, reg2, reg3, ...) \
do { \
register unsigned long r0 asm("r0"); \
- register unsigned long r1 asm("r1"); \
- register unsigned long r2 asm("r2"); \
- register unsigned long r3 asm("r3"); \
+ register unsigned long r1 asm(reg1); \
+ register unsigned long r2 asm(reg2); \
+ register unsigned long r3 asm(reg3); \
__declare_args(__count_args(__VA_ARGS__), __VA_ARGS__); \
asm volatile(inst "\n" : \
"=r" (r0), "=r" (r1), "=r" (r2), "=r" (r3) \
@@ -328,7 +328,8 @@ asmlinkage void __arm_smccc_hvc(unsigned long a0, unsigned long a1,
* to the SMC instruction. The return values are updated with the content
* from register 0 to 3 on return from the SMC instruction if not NULL.
*/
-#define arm_smccc_1_1_smc(...) __arm_smccc_1_1(SMCCC_SMC_INST, __VA_ARGS__)
+#define arm_smccc_1_1_smc(...)\
+ __arm_smccc_1_1(SMCCC_SMC_INST, "r1", "r2", "r3", __VA_ARGS__)
/*
* arm_smccc_1_1_hvc() - make an SMCCC v1.1 compliant HVC call
@@ -344,7 +345,23 @@ asmlinkage void __arm_smccc_hvc(unsigned long a0, unsigned long a1,
* to the HVC instruction. The return values are updated with the content
* from register 0 to 3 on return from the HVC instruction if not NULL.
*/
-#define arm_smccc_1_1_hvc(...) __arm_smccc_1_1(SMCCC_HVC_INST, __VA_ARGS__)
+#define arm_smccc_1_1_hvc(...) \
+ __arm_smccc_1_1(SMCCC_HVC_INST, "r1", "r2", "r3", __VA_ARGS__)
+
+/*
+ * arm_smccc_1_1_hvc_reg() - make an SMCCC v1.1 compliant HVC call
+ * specifying output registers
+ *
+ * This is a variant of arm_smccc_1_1_hvc() that allows specifying
+ * three registers from which result values will be returned in
+ * addition to r0.
+ *
+ * @a0-a2: register specifications for 3 return registers (e.g., "r5")
+ * @a3-a10: arguments passed in registers 0 to 7
+ * @res: result values from register 0 and the three registers specified
+ * in a0-a2.
+ */
+#define arm_smccc_1_1_hvc_reg(...) __arm_smccc_1_1(SMCCC_HVC_INST, __VA_ARGS__)
/*
* Like arm_smccc_1_1* but always returns SMCCC_RET_NOT_SUPPORTED.
--
1.8.3.1
next prev parent reply other threads:[~2021-03-08 19:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 19:57 [PATCH v9 0/7] Enable Linux guests on Hyper-V on ARM64 Michael Kelley
2021-03-08 19:57 ` Michael Kelley [this message]
2021-03-24 16:55 ` [PATCH v9 1/7] smccc: Add HVC call variant with result registers other than 0 thru 3 Mark Rutland
2021-03-25 4:55 ` Michael Kelley
2021-03-25 9:56 ` Mark Rutland
2021-03-25 17:19 ` Michael Kelley
2021-03-08 19:57 ` [PATCH v9 2/7] arm64: hyperv: Add Hyper-V hypercall and register access utilities Michael Kelley
2021-03-15 23:02 ` Sunil Muthuswamy
2021-03-08 19:57 ` [PATCH v9 3/7] arm64: hyperv: Add Hyper-V clocksource/clockevent support Michael Kelley
2021-03-08 19:57 ` [PATCH v9 4/7] arm64: hyperv: Add kexec and panic handlers Michael Kelley
2021-03-08 19:57 ` [PATCH v9 5/7] arm64: hyperv: Initialize hypervisor on boot Michael Kelley
2021-03-15 19:54 ` Sunil Muthuswamy
2021-03-08 19:57 ` [PATCH v9 6/7] arm64: efi: Export screen_info Michael Kelley
2021-03-08 19:57 ` [PATCH v9 7/7] Drivers: hv: Enable Hyper-V code to be built on ARM64 Michael Kelley
2021-03-24 15:54 ` [PATCH v9 0/7] Enable Linux guests on Hyper-V " Michael Kelley
2021-04-05 17:45 ` Michael Kelley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1615233439-23346-2-git-send-email-mikelley@microsoft.com \
--to=mikelley@microsoft.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=kys@microsoft.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=sudeep.holla@arm.com \
--cc=wei.liu@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).