From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Hannes Reinecke <hare@suse.de>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Robert Love <robert.w.love@intel.com>,
Arnd Bergmann <arnd@kernel.org>, Vasu Dev <vasu.dev@intel.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] scsi: fcoe: fix mismatched fcoe_wwn_from_mac declaration
Date: Tue, 6 Apr 2021 00:53:20 -0400 [thread overview]
Message-ID: <161768454092.32082.5587252008016665095.b4-ty@oracle.com> (raw)
In-Reply-To: <20210322164702.957810-1-arnd@kernel.org>
On Mon, 22 Mar 2021 17:46:59 +0100, Arnd Bergmann wrote:
> An old cleanup changed the array size from MAX_ADDR_LEN to
> unspecified in the declaration, but now gcc-11 warns about this:
>
> drivers/scsi/fcoe/fcoe_ctlr.c:1972:37: error: argument 1 of type ‘unsigned char[32]’ with mismatched bound [-Werror=array-parameter=]
> 1972 | u64 fcoe_wwn_from_mac(unsigned char mac[MAX_ADDR_LEN],
> | ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
> In file included from /git/arm-soc/drivers/scsi/fcoe/fcoe_ctlr.c:33:
> include/scsi/libfcoe.h:252:37: note: previously declared as ‘unsigned char[]’
> 252 | u64 fcoe_wwn_from_mac(unsigned char mac[], unsigned int, unsigned int);
> | ~~~~~~~~~~~~~~^~~~~
>
> [...]
Applied to 5.13/scsi-queue, thanks!
[1/1] scsi: fcoe: fix mismatched fcoe_wwn_from_mac declaration
https://git.kernel.org/mkp/scsi/c/5b11c9d80bde
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2021-04-06 4:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 16:46 [PATCH] scsi: fcoe: fix mismatched fcoe_wwn_from_mac declaration Arnd Bergmann
2021-04-06 4:53 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161768454092.32082.5587252008016665095.b4-ty@oracle.com \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=hare@suse.de \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=robert.w.love@intel.com \
--cc=vasu.dev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).