* [PATCH] scsi: bfa: remove unneeded flush_workqueue
@ 2022-04-24 6:18 cgel.zte
2022-05-03 0:51 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-04-24 6:18 UTC (permalink / raw
To: anil.gurumurthy
Cc: sudarsana.kalluru, jejb, martin.petersen, linux-scsi,
linux-kernel, ran jianping, Zeal Robot
From: ran jianping <ran.jianping@zte.com.cn>
All work currently pending will be done first by calling destroy_workqueue,
so there is no need to flush it explicitly.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ran jianping <ran.jianping@zte.com.cn>
---
drivers/scsi/bfa/bfad_im.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/bfa/bfad_im.c b/drivers/scsi/bfa/bfad_im.c
index 8419a1a89485..c335f7a188d2 100644
--- a/drivers/scsi/bfa/bfad_im.c
+++ b/drivers/scsi/bfa/bfad_im.c
@@ -755,7 +755,6 @@ void
bfad_destroy_workq(struct bfad_im_s *im)
{
if (im && im->drv_workq) {
- flush_workqueue(im->drv_workq);
destroy_workqueue(im->drv_workq);
im->drv_workq = NULL;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: bfa: remove unneeded flush_workqueue
2022-04-24 6:18 [PATCH] scsi: bfa: remove unneeded flush_workqueue cgel.zte
@ 2022-05-03 0:51 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2022-05-03 0:51 UTC (permalink / raw
To: anil.gurumurthy, cgel.zte
Cc: Martin K . Petersen, ran jianping, linux-kernel, jejb, Zeal Robot,
sudarsana.kalluru, linux-scsi
On Sun, 24 Apr 2022 06:18:45 +0000, cgel.zte@gmail.com wrote:
> From: ran jianping <ran.jianping@zte.com.cn>
>
> All work currently pending will be done first by calling destroy_workqueue,
> so there is no need to flush it explicitly.
>
>
Applied to 5.19/scsi-queue, thanks!
[1/1] scsi: bfa: remove unneeded flush_workqueue
https://git.kernel.org/mkp/scsi/c/4c0df601e150
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-03 15:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-24 6:18 [PATCH] scsi: bfa: remove unneeded flush_workqueue cgel.zte
2022-05-03 0:51 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).