* [PATCH] caif: don't assume iov_iter type
@ 2023-01-11 18:42 Keith Busch
2023-01-11 21:58 ` Jens Axboe
2023-01-14 5:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Keith Busch @ 2023-01-11 18:42 UTC (permalink / raw
To: netdev
Cc: davem, edumazet, kuba, pabeni, axboe, io-uring, linux-kernel,
Keith Busch
From: Keith Busch <kbusch@kernel.org>
The details of the iov_iter types are appropriately abstracted, so
there's no need to check for specific type fields. Just let the
abstractions handle it.
This is preparing for io_uring/net's io_send to utilize the more
efficient ITER_UBUF.
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
net/caif/caif_socket.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/net/caif/caif_socket.c b/net/caif/caif_socket.c
index 748be72532485..1f2c1d7b90e23 100644
--- a/net/caif/caif_socket.c
+++ b/net/caif/caif_socket.c
@@ -533,10 +533,6 @@ static int caif_seqpkt_sendmsg(struct socket *sock, struct msghdr *msg,
if (msg->msg_namelen)
goto err;
- ret = -EINVAL;
- if (unlikely(msg->msg_iter.nr_segs == 0) ||
- unlikely(msg->msg_iter.iov->iov_base == NULL))
- goto err;
noblock = msg->msg_flags & MSG_DONTWAIT;
timeo = sock_sndtimeo(sk, noblock);
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] caif: don't assume iov_iter type
2023-01-11 18:42 [PATCH] caif: don't assume iov_iter type Keith Busch
@ 2023-01-11 21:58 ` Jens Axboe
2023-01-14 5:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2023-01-11 21:58 UTC (permalink / raw
To: Keith Busch, netdev
Cc: davem, edumazet, kuba, pabeni, io-uring, linux-kernel,
Keith Busch
On 1/11/23 11:42 AM, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> The details of the iov_iter types are appropriately abstracted, so
> there's no need to check for specific type fields. Just let the
> abstractions handle it.
>
> This is preparing for io_uring/net's io_send to utilize the more
> efficient ITER_UBUF.
Looks good to me - the correct return here would be -EFAULT as well,
not -EINVAL. Which is what will happen once memcpy_from_msg() is
called anyway.
Reviewed-by: Jens Axboe <axboe@kernel.dk>
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] caif: don't assume iov_iter type
2023-01-11 18:42 [PATCH] caif: don't assume iov_iter type Keith Busch
2023-01-11 21:58 ` Jens Axboe
@ 2023-01-14 5:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-01-14 5:00 UTC (permalink / raw
To: Keith Busch
Cc: netdev, davem, edumazet, kuba, pabeni, axboe, io-uring,
linux-kernel, kbusch
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 11 Jan 2023 10:42:45 -0800 you wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> The details of the iov_iter types are appropriately abstracted, so
> there's no need to check for specific type fields. Just let the
> abstractions handle it.
>
> This is preparing for io_uring/net's io_send to utilize the more
> efficient ITER_UBUF.
>
> [...]
Here is the summary with links:
- caif: don't assume iov_iter type
https://git.kernel.org/netdev/net-next/c/c19175141079
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-14 5:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-11 18:42 [PATCH] caif: don't assume iov_iter type Keith Busch
2023-01-11 21:58 ` Jens Axboe
2023-01-14 5:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).