From: Randy Dunlap <rdunlap@infradead.org>
To: Kent Overstreet <kent.overstreet@linux.dev>,
axboe@kernel.dk, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH v2 5/5] block: CONFIG_BLK_DEBUG
Date: Mon, 5 Jun 2023 15:41:55 -0700 [thread overview]
Message-ID: <17f2f270-abff-8db7-c91e-bece1a61254a@infradead.org> (raw)
In-Reply-To: <20230605212717.2570570-5-kent.overstreet@linux.dev>
Hi,
On 6/5/23 14:27, Kent Overstreet wrote:
> diff --git a/block/Kconfig b/block/Kconfig
> index 86122e459f..611dddb59c 100644
> --- a/block/Kconfig
> +++ b/block/Kconfig
> @@ -165,6 +165,13 @@ config BLK_CGROUP_IOPRIO
> scheduler and block devices process requests. Only some I/O schedulers
> and some block devices support I/O priorities.
>
> +config BLK_DEBUG
> + bool "Extra block layer assertions"
> + depends on DEBUG_KERNEL
> + help
> + Enable extra assertions in the block layer. Currently this is just the
> + bio iterator code, but may be expanded.
I see that block/Kconfig isn't consistent about indenting help text,
but Documentation/process/coding-style.rst says:
10) Kconfig configuration files
-------------------------------
For all of the Kconfig* configuration files throughout the source tree,
the indentation is somewhat different. Lines under a ``config`` definition
are indented with one tab, while help text is indented an additional two
spaces.
so please add 2 spaces after the tab at the beginning of the help text
lines (but not the "help" line itself).
--
~Randy
next prev parent reply other threads:[~2023-06-05 22:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 21:27 [PATCH v2 1/5] block: Rework bio_for_each_segment_all() Kent Overstreet
2023-06-05 21:27 ` [PATCH v2 2/5] block: Rework bio_for_each_folio_all() Kent Overstreet
2023-06-05 21:27 ` [PATCH v2 3/5] block: Add documentation for bio iterator macros Kent Overstreet
2023-06-05 21:27 ` [PATCH v2 4/5] block: Change memcpy_(to|from)_bvec to pass bvec by value Kent Overstreet
2023-06-06 7:31 ` kernel test robot
2023-06-05 21:27 ` [PATCH v2 5/5] block: CONFIG_BLK_DEBUG Kent Overstreet
2023-06-05 22:41 ` Randy Dunlap [this message]
2023-06-06 2:03 ` [PATCH v2 1/5] block: Rework bio_for_each_segment_all() Ming Lei
2023-06-06 7:29 ` Kent Overstreet
2023-06-09 20:44 ` Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17f2f270-abff-8db7-c91e-bece1a61254a@infradead.org \
--to=rdunlap@infradead.org \
--cc=axboe@kernel.dk \
--cc=kent.overstreet@linux.dev \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).