From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757449AbbEEKma (ORCPT ); Tue, 5 May 2015 06:42:30 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:36016 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753132AbbEEKmW (ORCPT ); Tue, 5 May 2015 06:42:22 -0400 Date: Tue, 5 May 2015 11:42:17 +0100 From: Lee Jones To: Shobhit Kumar Cc: Shobhit Kumar , linux-pwm , Jani Nikula , Samuel Ortiz , Alexandre Courbot , Povilas Staniulis , intel-gfx , linux-kernel , dri-devel , linux-gpio , Daniel Vetter Subject: Re: [PATCH 5/8] drivers/mfd: ADD PWM lookup table for CRC PMIC based PWM Message-ID: <20150505104217.GY4047@x1> References: <1430316005-16480-1-git-send-email-shobhit.kumar@intel.com> <1430316005-16480-6-git-send-email-shobhit.kumar@intel.com> <20150429142451.GS9169@x1> <554891EA.7050906@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <554891EA.7050906@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 05 May 2015, Shobhit Kumar wrote: > On 04/29/2015 07:54 PM, Lee Jones wrote: > > On Wed, 29 Apr 2015, Shobhit Kumar wrote: > > > >> On some BYT PLatform the PWM is controlled using CRC PMIC. Add a lookup > >> entry for the same to be used by the consumer (Intel GFX) > >> > >> v2: Remove the lookup table on driver unload (Thierry) > >> > >> CC: Samuel Ortiz > >> Cc: Linus Walleij > >> Cc: Alexandre Courbot > >> Cc: Thierry Reding > >> Signed-off-by: Shobhit Kumar > >> --- > >> drivers/mfd/intel_soc_pmic_core.c | 12 ++++++++++++ > >> 1 file changed, 12 insertions(+) > > > > How do you expect this set to be managed? > > There are some dependencies on the look up table remove functionality in > earlier patches, so I think 3/8 can go in only after 1/8. Similarly 5/8 > can go only after 2/8. Rest all can be independent. Taking patches 'in order' is tough to coordinate and takes a very long time. The best thing to do is have all of the patches taken in via a single tree at the same time. > > Acked-by: Lee Jones > > > >> diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c > >> index f3d918e..a00ddd9 100644 > >> --- a/drivers/mfd/intel_soc_pmic_core.c > >> +++ b/drivers/mfd/intel_soc_pmic_core.c > >> @@ -25,6 +25,7 @@ > >> #include > >> #include > >> #include > >> +#include > >> #include "intel_soc_pmic_core.h" > >> > >> /* Lookup table for the Panel Enable/Disable line as GPIO signals */ > >> @@ -37,6 +38,11 @@ static struct gpiod_lookup_table panel_gpio_table = { > >> }, > >> }; > >> > >> +/* PWM consumed by the Intel GFX */ > >> +static struct pwm_lookup crc_pwm_lookup[] = { > >> + PWM_LOOKUP("crystal_cove_pwm", 0, "0000:00:02.0", "pwm_backlight", 0, PWM_POLARITY_NORMAL), > >> +}; > >> + > >> static int intel_soc_pmic_find_gpio_irq(struct device *dev) > >> { > >> struct gpio_desc *desc; > >> @@ -99,6 +105,9 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c, > >> /* Add lookup table binding for Panel Control to the GPIO Chip */ > >> gpiod_add_lookup_table(&panel_gpio_table); > >> > >> + /* Add lookup table for crc-pwm */ > >> + pwm_add_table(crc_pwm_lookup, ARRAY_SIZE(crc_pwm_lookup)); > >> + > >> ret = mfd_add_devices(dev, -1, config->cell_dev, > >> config->n_cell_devs, NULL, 0, > >> regmap_irq_get_domain(pmic->irq_chip_data)); > >> @@ -121,6 +130,9 @@ static int intel_soc_pmic_i2c_remove(struct i2c_client *i2c) > >> /* Remove lookup table for Panel Control from the GPIO Chip */ > >> gpiod_remove_lookup_table(&panel_gpio_table); > >> > >> + /* remove crc-pwm lookup table */ > >> + pwm_remove_table(crc_pwm_lookup, ARRAY_SIZE(crc_pwm_lookup)); > >> + > >> mfd_remove_devices(&i2c->dev); > >> > >> return 0; > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog