From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753748AbbGXBpZ (ORCPT ); Thu, 23 Jul 2015 21:45:25 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:33887 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752497AbbGXBpX (ORCPT ); Thu, 23 Jul 2015 21:45:23 -0400 Date: Thu, 23 Jul 2015 18:45:19 -0700 From: Brian Norris To: KOBAYASHI Yoshitake Cc: dwmw2@infradead.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] mtd: nand support for Toshiba BENAND (Built-in ECC NAND) Message-ID: <20150724014519.GG8876@google.com> References: <1437699138-24582-1-git-send-email-yoshitake.kobayashi@toshiba.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437699138-24582-1-git-send-email-yoshitake.kobayashi@toshiba.co.jp> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 24, 2015 at 09:52:18AM +0900, KOBAYASHI Yoshitake wrote: > This patch enables support for Toshiba BENAND. BENAND is a SLC NAND > solution that automatically generates ECC inside NAND chip. > > I considered to use the patch of on-die ECC, but I believe reading twice > the same page approach will affect read performance. Additionally, BENAND > does not support Disable ECC. So, I cannot use same approach. > > BENAND Read Status CMD(70h) is able to report Rewrite Recommend. BENAND > also has extended ECC Status CMD(7Ah). This command is able to report the > number of bit error/sector data. When MTD_NAND_BENAND_ENABLE option enabled, > this driver use the extended ECC status CMD(7Ah) to report real number of > bitflips. In case of difficult to use CMD(7Ah), this driver use > "mtd->bitflip_threshold" to assume the number of bitflips. > > Signed-off-by: KOBAYASHI Yoshitake > --- Where's the changelog? I see that this is version 3... Brian