LKML Archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: enable generic idle loop
@ 2015-08-21  3:40 Leo Yan
  2015-08-21  9:00 ` Catalin Marinas
  0 siblings, 1 reply; 8+ messages in thread
From: Leo Yan @ 2015-08-21  3:40 UTC (permalink / raw
  To: Catalin Marinas, Will Deacon, linux-arm-kernel, linux-kernel; +Cc: Leo Yan

Enable generic idle loop for ARM64, so can support for hlt/nohlt
command line options to override default idle loop behavior.

Signed-off-by: Leo Yan <leo.yan@linaro.org>
---
 arch/arm64/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index 0f6edb1..c404e74 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -31,6 +31,7 @@ config ARM64
 	select GENERIC_CLOCKEVENTS_BROADCAST if SMP
 	select GENERIC_CPU_AUTOPROBE
 	select GENERIC_EARLY_IOREMAP
+	select GENERIC_IDLE_POLL_SETUP
 	select GENERIC_IRQ_PROBE
 	select GENERIC_IRQ_SHOW
 	select GENERIC_IRQ_SHOW_LEVEL
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] arm64: enable generic idle loop
  2015-08-21  3:40 [PATCH] arm64: enable generic idle loop Leo Yan
@ 2015-08-21  9:00 ` Catalin Marinas
  2015-08-21  9:14   ` Leo Yan
  0 siblings, 1 reply; 8+ messages in thread
From: Catalin Marinas @ 2015-08-21  9:00 UTC (permalink / raw
  To: Leo Yan; +Cc: Will Deacon, linux-arm-kernel, linux-kernel

On Fri, Aug 21, 2015 at 11:40:22AM +0800, Leo Yan wrote:
> Enable generic idle loop for ARM64, so can support for hlt/nohlt
> command line options to override default idle loop behavior.

Just curious, what do you need this for?

-- 
Catalin

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] arm64: enable generic idle loop
  2015-08-21  9:00 ` Catalin Marinas
@ 2015-08-21  9:14   ` Leo Yan
  2015-08-21 15:54     ` Catalin Marinas
  0 siblings, 1 reply; 8+ messages in thread
From: Leo Yan @ 2015-08-21  9:14 UTC (permalink / raw
  To: Catalin Marinas; +Cc: Will Deacon, linux-arm-kernel, linux-kernel

On Fri, Aug 21, 2015 at 10:00:43AM +0100, Catalin Marinas wrote:
> On Fri, Aug 21, 2015 at 11:40:22AM +0800, Leo Yan wrote:
> > Enable generic idle loop for ARM64, so can support for hlt/nohlt
> > command line options to override default idle loop behavior.
> 
> Just curious, what do you need this for?

With this config, usually we can add "nohlt" in command line to force
the cpu will never be powered off; so can quickly narrow down if some
issues are related with cpuidle or not.

And if CPU is powered off, then its debug logic also will be powered off.
So we can simply use this method to let debugger always hot connect with
the target CPU.

Thanks,
Leo Yan

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] arm64: enable generic idle loop
  2015-08-21  9:14   ` Leo Yan
@ 2015-08-21 15:54     ` Catalin Marinas
  2015-09-15 11:20       ` Leo Yan
  0 siblings, 1 reply; 8+ messages in thread
From: Catalin Marinas @ 2015-08-21 15:54 UTC (permalink / raw
  To: Leo Yan; +Cc: Will Deacon, linux-kernel, linux-arm-kernel

On Fri, Aug 21, 2015 at 05:14:46PM +0800, Leo Yan wrote:
> On Fri, Aug 21, 2015 at 10:00:43AM +0100, Catalin Marinas wrote:
> > On Fri, Aug 21, 2015 at 11:40:22AM +0800, Leo Yan wrote:
> > > Enable generic idle loop for ARM64, so can support for hlt/nohlt
> > > command line options to override default idle loop behavior.
> > 
> > Just curious, what do you need this for?
> 
> With this config, usually we can add "nohlt" in command line to force
> the cpu will never be powered off; so can quickly narrow down if some
> issues are related with cpuidle or not.
> 
> And if CPU is powered off, then its debug logic also will be powered off.
> So we can simply use this method to let debugger always hot connect with
> the target CPU.

OK.

Acked-by: Catalin Marinas <catalin.marinas@arm.com>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] arm64: enable generic idle loop
  2015-08-21 15:54     ` Catalin Marinas
@ 2015-09-15 11:20       ` Leo Yan
  2015-09-15 14:31         ` Catalin Marinas
  0 siblings, 1 reply; 8+ messages in thread
From: Leo Yan @ 2015-09-15 11:20 UTC (permalink / raw
  To: Catalin Marinas; +Cc: Will Deacon, linux-kernel, linux-arm-kernel

Hi Will,

On Fri, Aug 21, 2015 at 04:54:25PM +0100, Catalin Marinas wrote:
> On Fri, Aug 21, 2015 at 05:14:46PM +0800, Leo Yan wrote:
> > On Fri, Aug 21, 2015 at 10:00:43AM +0100, Catalin Marinas wrote:
> > > On Fri, Aug 21, 2015 at 11:40:22AM +0800, Leo Yan wrote:
> > > > Enable generic idle loop for ARM64, so can support for hlt/nohlt
> > > > command line options to override default idle loop behavior.
> > > 
> > > Just curious, what do you need this for?
> > 
> > With this config, usually we can add "nohlt" in command line to force
> > the cpu will never be powered off; so can quickly narrow down if some
> > issues are related with cpuidle or not.
> > 
> > And if CPU is powered off, then its debug logic also will be powered off.
> > So we can simply use this method to let debugger always hot connect with
> > the target CPU.
> 
> OK.
> 
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>

Suppose you have missed this patch at previous merge window,
so just for reminding.

Thanks,
Leo Yan

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] arm64: enable generic idle loop
  2015-09-15 11:20       ` Leo Yan
@ 2015-09-15 14:31         ` Catalin Marinas
  2015-09-15 14:44           ` Will Deacon
  0 siblings, 1 reply; 8+ messages in thread
From: Catalin Marinas @ 2015-09-15 14:31 UTC (permalink / raw
  To: Leo Yan; +Cc: Will Deacon, linux-kernel, linux-arm-kernel

On Tue, Sep 15, 2015 at 07:20:08PM +0800, Leo Yan wrote:
> On Fri, Aug 21, 2015 at 04:54:25PM +0100, Catalin Marinas wrote:
> > On Fri, Aug 21, 2015 at 05:14:46PM +0800, Leo Yan wrote:
> > > On Fri, Aug 21, 2015 at 10:00:43AM +0100, Catalin Marinas wrote:
> > > > On Fri, Aug 21, 2015 at 11:40:22AM +0800, Leo Yan wrote:
> > > > > Enable generic idle loop for ARM64, so can support for hlt/nohlt
> > > > > command line options to override default idle loop behavior.
> > > > 
> > > > Just curious, what do you need this for?
> > > 
> > > With this config, usually we can add "nohlt" in command line to force
> > > the cpu will never be powered off; so can quickly narrow down if some
> > > issues are related with cpuidle or not.
> > > 
> > > And if CPU is powered off, then its debug logic also will be powered off.
> > > So we can simply use this method to let debugger always hot connect with
> > > the target CPU.
> > 
> > OK.
> > 
> > Acked-by: Catalin Marinas <catalin.marinas@arm.com>
> 
> Suppose you have missed this patch at previous merge window,
> so just for reminding.

It looks like it missed the merging window. Will, can this still be
picked for 4.3? If not, it will be 4.4.

-- 
Catalin

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] arm64: enable generic idle loop
  2015-09-15 14:31         ` Catalin Marinas
@ 2015-09-15 14:44           ` Will Deacon
  2015-09-15 14:51             ` Leo Yan
  0 siblings, 1 reply; 8+ messages in thread
From: Will Deacon @ 2015-09-15 14:44 UTC (permalink / raw
  To: Catalin Marinas
  Cc: leo.yan@linaro.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org

On Tue, Sep 15, 2015 at 03:31:35PM +0100, Catalin Marinas wrote:
> On Tue, Sep 15, 2015 at 07:20:08PM +0800, Leo Yan wrote:
> > On Fri, Aug 21, 2015 at 04:54:25PM +0100, Catalin Marinas wrote:
> > > On Fri, Aug 21, 2015 at 05:14:46PM +0800, Leo Yan wrote:
> > > > On Fri, Aug 21, 2015 at 10:00:43AM +0100, Catalin Marinas wrote:
> > > > > On Fri, Aug 21, 2015 at 11:40:22AM +0800, Leo Yan wrote:
> > > > > > Enable generic idle loop for ARM64, so can support for hlt/nohlt
> > > > > > command line options to override default idle loop behavior.
> > > > > 
> > > > > Just curious, what do you need this for?
> > > > 
> > > > With this config, usually we can add "nohlt" in command line to force
> > > > the cpu will never be powered off; so can quickly narrow down if some
> > > > issues are related with cpuidle or not.
> > > > 
> > > > And if CPU is powered off, then its debug logic also will be powered off.
> > > > So we can simply use this method to let debugger always hot connect with
> > > > the target CPU.
> > > 
> > > OK.
> > > 
> > > Acked-by: Catalin Marinas <catalin.marinas@arm.com>
> > 
> > Suppose you have missed this patch at previous merge window,
> > so just for reminding.
> 
> It looks like it missed the merging window. Will, can this still be
> picked for 4.3? If not, it will be 4.4.

Yeah, it's harmless enough to pick up with the current crop of fixes.
Sorry I missed it.

Will

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] arm64: enable generic idle loop
  2015-09-15 14:44           ` Will Deacon
@ 2015-09-15 14:51             ` Leo Yan
  0 siblings, 0 replies; 8+ messages in thread
From: Leo Yan @ 2015-09-15 14:51 UTC (permalink / raw
  To: Will Deacon
  Cc: Catalin Marinas, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org

On Tue, Sep 15, 2015 at 03:44:09PM +0100, Will Deacon wrote:
> On Tue, Sep 15, 2015 at 03:31:35PM +0100, Catalin Marinas wrote:
> > On Tue, Sep 15, 2015 at 07:20:08PM +0800, Leo Yan wrote:
> > > On Fri, Aug 21, 2015 at 04:54:25PM +0100, Catalin Marinas wrote:
> > > > On Fri, Aug 21, 2015 at 05:14:46PM +0800, Leo Yan wrote:
> > > > > On Fri, Aug 21, 2015 at 10:00:43AM +0100, Catalin Marinas wrote:
> > > > > > On Fri, Aug 21, 2015 at 11:40:22AM +0800, Leo Yan wrote:
> > > > > > > Enable generic idle loop for ARM64, so can support for hlt/nohlt
> > > > > > > command line options to override default idle loop behavior.
> > > > > > 
> > > > > > Just curious, what do you need this for?
> > > > > 
> > > > > With this config, usually we can add "nohlt" in command line to force
> > > > > the cpu will never be powered off; so can quickly narrow down if some
> > > > > issues are related with cpuidle or not.
> > > > > 
> > > > > And if CPU is powered off, then its debug logic also will be powered off.
> > > > > So we can simply use this method to let debugger always hot connect with
> > > > > the target CPU.
> > > > 
> > > > OK.
> > > > 
> > > > Acked-by: Catalin Marinas <catalin.marinas@arm.com>
> > > 
> > > Suppose you have missed this patch at previous merge window,
> > > so just for reminding.
> > 
> > It looks like it missed the merging window. Will, can this still be
> > picked for 4.3? If not, it will be 4.4.
> 
> Yeah, it's harmless enough to pick up with the current crop of fixes.
> Sorry I missed it.

It's fine and thanks :)

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2015-09-15 14:51 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-21  3:40 [PATCH] arm64: enable generic idle loop Leo Yan
2015-08-21  9:00 ` Catalin Marinas
2015-08-21  9:14   ` Leo Yan
2015-08-21 15:54     ` Catalin Marinas
2015-09-15 11:20       ` Leo Yan
2015-09-15 14:31         ` Catalin Marinas
2015-09-15 14:44           ` Will Deacon
2015-09-15 14:51             ` Leo Yan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).