* include/net/tcp_memcontrol.h:4:54: warning: ‘struct cgroup_subsys’ declared inside parameter list
@ 2016-01-16 16:48 Borislav Petkov
2016-01-18 0:05 ` Johannes Weiner
0 siblings, 1 reply; 3+ messages in thread
From: Borislav Petkov @ 2016-01-16 16:48 UTC (permalink / raw
To: Johannes Weiner; +Cc: lkml
Moin Johannes,
you're the last touching net/ipv4/tcp_memcontrol.c, so here you go :-P
In file included from net/ipv4/tcp_ipv4.c:76:0:
include/net/tcp_memcontrol.h:4:54: warning: ‘struct cgroup_subsys’ declared inside parameter list
int tcp_init_cgroup(struct mem_cgroup *memcg, struct cgroup_subsys *ss);
^
include/net/tcp_memcontrol.h:4:54: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv6/tcp_ipv6.c:64:0:
include/net/tcp_memcontrol.h:4:54: warning: ‘struct cgroup_subsys’ declared inside parameter list
int tcp_init_cgroup(struct mem_cgroup *memcg, struct cgroup_subsys *ss);
^
include/net/tcp_memcontrol.h:4:54: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/sysctl_net_ipv4.c:27:0:
include/net/tcp_memcontrol.h:4:54: warning: ‘struct cgroup_subsys’ declared inside parameter list
int tcp_init_cgroup(struct mem_cgroup *memcg, struct cgroup_subsys *ss);
^
include/net/tcp_memcontrol.h:4:54: warning: its scope is only this definition or declaration, which is probably not what you want
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: include/net/tcp_memcontrol.h:4:54: warning: ‘struct cgroup_subsys’ declared inside parameter list
2016-01-16 16:48 include/net/tcp_memcontrol.h:4:54: warning: ‘struct cgroup_subsys’ declared inside parameter list Borislav Petkov
@ 2016-01-18 0:05 ` Johannes Weiner
2016-01-18 0:10 ` Borislav Petkov
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Weiner @ 2016-01-18 0:05 UTC (permalink / raw
To: Borislav Petkov; +Cc: lkml
Guten Nachmittag Boris,
On Sat, Jan 16, 2016 at 05:48:33PM +0100, Borislav Petkov wrote:
> In file included from net/ipv4/tcp_ipv4.c:76:0:
> include/net/tcp_memcontrol.h:4:54: warning: ‘struct cgroup_subsys’ declared inside parameter list
> int tcp_init_cgroup(struct mem_cgroup *memcg, struct cgroup_subsys *ss);
> ^
> include/net/tcp_memcontrol.h:4:54: warning: its scope is only this definition or declaration, which is probably not what you want
thanks for the report. All this code (tcp_memcontrol.*) is already
deleted in -mm, so the issue should be fixed once Andrew sends the
next batch for this merge window linuswards.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: include/net/tcp_memcontrol.h:4:54: warning: ‘struct cgroup_subsys’ declared inside parameter list
2016-01-18 0:05 ` Johannes Weiner
@ 2016-01-18 0:10 ` Borislav Petkov
0 siblings, 0 replies; 3+ messages in thread
From: Borislav Petkov @ 2016-01-18 0:10 UTC (permalink / raw
To: Johannes Weiner; +Cc: lkml
On Sun, Jan 17, 2016 at 07:05:57PM -0500, Johannes Weiner wrote:
> thanks for the report. All this code (tcp_memcontrol.*) is already
> deleted in -mm, so the issue should be fixed once Andrew sends the
> next batch for this merge window linuswards.
I see David applied this:
https://lkml.kernel.org/r/1453026637-9942-1-git-send-email-geert@linux-m68k.org
I guess it is moot now.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-18 0:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-16 16:48 include/net/tcp_memcontrol.h:4:54: warning: ‘struct cgroup_subsys’ declared inside parameter list Borislav Petkov
2016-01-18 0:05 ` Johannes Weiner
2016-01-18 0:10 ` Borislav Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).