From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752783AbcA0BxL (ORCPT ); Tue, 26 Jan 2016 20:53:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55598 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751383AbcA0BxJ (ORCPT ); Tue, 26 Jan 2016 20:53:09 -0500 Date: Tue, 26 Jan 2016 20:53:05 -0500 From: Jessica Yu To: Miroslav Benes Cc: Torsten Duwe , Steven Rostedt , Michael Ellerman , Jiri Kosina , linuxppc-dev@lists.ozlabs.org, Linux Kernel Mailing List , live-patching@vger.kernel.org, pmladek@suse.cz Subject: Re: Implement kernel live patching for ppc64le (ABIv2) Message-ID: <20160127015304.GA19619@packer-debian-8-amd64.digitalocean.com> References: <20160125170459.14DB7692CE@newverein.lst.de> <20160125170804.A11DB692DD@newverein.lst.de> <20160126140027.GB28664@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-OS: Linux eisen.io 3.16.0-4-amd64 x86_64 User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +++ Miroslav Benes [26/01/16 15:14 +0100]: > >[ Jessica added to CC list so she is aware that there are plans to >implement livepatch on ppc64le ] > >On Tue, 26 Jan 2016, Torsten Duwe wrote: > >> On Tue, Jan 26, 2016 at 11:50:25AM +0100, Miroslav Benes wrote: >> > > + */ >> > > +int klp_write_module_reloc(struct module *mod, unsigned long type, >> > > + unsigned long loc, unsigned long value) >> > > +{ >> > > + /* This requires infrastructure changes; we need the loadinfos. */ >> > > + pr_err("lpc_write_module_reloc not yet supported\n"); >> > >> > This is a nit, but there is no lpc_write_module_reloc. It should be >> > klp_write_module_reloc. >> >> Indeed. Michael, feel free to fix this on the fly or not. It needs to >> disappear anyway and be replaced with functionality. > >Or not at all thanks to Jessica's effort [1]. > >Miroslav > >[1] http://lkml.kernel.org/g/1452281304-28618-1-git-send-email-jeyu@redhat.com Miroslav, thanks for the CC. Indeed, if things go well, there may be no need to implement klp_write_module_reloc() anymore in the near future. :-) Jessica