From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752828AbcBASp6 (ORCPT ); Mon, 1 Feb 2016 13:45:58 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:53229 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751726AbcBASpz (ORCPT ); Mon, 1 Feb 2016 13:45:55 -0500 Date: Mon, 1 Feb 2016 19:45:05 +0100 From: Karsten Merker To: Andre Przywara , Maxime Ripard , Chen-Yu Tsai , linux-sunxi@googlegroups.com, Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linus Walleij , Vishnu Patekar , linux-gpio@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org Subject: Re: [linux-sunxi] Re: [PATCH 05/11] drivers: pinctrl: add driver for Allwinner A64 SoC Message-ID: <20160201184505.GB14737@excalibur.cnev.de> References: <1454348370-3816-1-git-send-email-andre.przywara@arm.com> <1454348370-3816-6-git-send-email-andre.przywara@arm.com> <20160201182754.GA14737@excalibur.cnev.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160201182754.GA14737@excalibur.cnev.de> X-No-Archive: yes User-Agent: Mutt/1.5.23 (2014-03-12) X-Provags-ID: V03:K0:3til40zFcggTuQoyeHoGz0C7TiihUzMD0cih2lltx3WCdiWqmtU +81RsAntnmyeKOwxH8gQPA2p33ehpjrjfu7M0yqLP40/Alt92bqjdf31/nfbE9sl6thhnvC Zu86HTHwfN4JN5WUP/pVJ4n9sJSsK0dAwz22yGTBNdtk3JYwJqLKA+OgXsCSeUxivY/bdJO Tgl/Xjf+4MF0P8dXhOe7g== X-UI-Out-Filterresults: notjunk:1;V01:K0:0elAW8KL4vw=:A3o2bzZ77OOiIL6yU3kYqT O7lezmooP0P+WmpcmNc2doY7Ab0gQRa0nC1twgwVm0krLU8p6yz49bujUWHWGUxIutsIy2KxO 22wE7TyadouT4HirFHXD9g8cl0DQHebsH78tazZeXFfnxUN4EVovMPCG0c4mW8OP1yTCcmcS/ A5DRIuS4XurMbpDz6nKkVccMHnYxJnAdhIHB1+f7/qVJZrRSlUbP9qoOIvwo5hCaQu655wFeZ HqJl7yHxMIyNCDQuHszYPo0cOU7cplnPNe9IyOPO8zKbzZFX6jgkdIvR8cNGTDjAZ4oZK2ViB jOPB8yMsWh+uMom+914p4srr27RoCX23WoeV5ro5jAALezVtsOkV1nkpLKwPJcNzMJHdyfixW VbDS8jxiYdmMYUrliKI/yvX4wIBsUAS3J0oPW/B41OihSeC/drzqNe8BGRcZ/jIlDm4O/a/PW Z1AydYhVzNn0CoOdg/ah/arY1YiVwbuzwW8qE+A/z2RjXIgYJ4nMoKU/lRKWH1e5KEj6u2hDU A5O+KchyihKiXmtH1mwkYoHsto5HcozJAGFu4Hjf7LwYL5VPwa2Gd+R3pkOqWocjVAGLISNQR gGJ8XkfLnGfykzmQI/EzVQg9jGY+yQYvN7E0JkaLfz8AcI4q62icELbLxtIlBPAyBQkitacH3 FzUvRPTUyvx6mioYLHN0OtoizzLP7Jql9W1mSIFdsWZgAtZTnlAXXIHaoteJUIxRJIys= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, I by mistake pressed "send" on my previous mail when I intended to further edit it, so here comes a followup. I definitely need more coffee ;-). On Mon, Feb 01, 2016 at 07:27:54PM +0100, Karsten Merker wrote: > On Mon, Feb 01, 2016 at 05:39:24PM +0000, Andre Przywara wrote: > > +static const struct sunxi_pinctrl_desc a64_pinctrl_data = { > > + .pins = a64_pins, > > + .npins = ARRAY_SIZE(a64_pins), > > + .irq_banks = 3, > > +}; > > + > > +static int a64_pinctrl_probe(struct platform_device *pdev) > > +{ > > + return sunxi_pinctrl_init(pdev, > > + &a64_pinctrl_data); > > +} > > + > > +static const struct of_device_id a64_pinctrl_match[] = { > > + { .compatible = "allwinner,a64-pinctrl", }, s/allwinner,a64-pinctrl/allwinner,sun50i-a64-pinctrl/ ? > > + {} > > +}; > > +MODULE_DEVICE_TABLE(of, a64_pinctrl_match); > > + > > +static struct platform_driver a64_pinctrl_driver = { > > + .probe = a64_pinctrl_probe, > > + .driver = { > > + .name = "a64-pinctrl", > > + .of_match_table = a64_pinctrl_match, > > + }, > > +}; > > +module_platform_driver(a64_pinctrl_driver); > > + > > +MODULE_AUTHOR("Andre Przywara "); > > +MODULE_DESCRIPTION("Allwinner A64 pinctrl driver"); > > +MODULE_LICENSE("GPL"); > > For the above function names one could also think about using the s/function names/variable definitions/ > existing naming scheme including the SoC family as we do in the > other sunxi pinctrl drivers, but as they are only internal to the > driver, that would really just be a matter of cosmetics :-). Regards, Karsten -- Gem. Par. 28 Abs. 4 Bundesdatenschutzgesetz widerspreche ich der Nutzung sowie der Weitergabe meiner personenbezogenen Daten für Zwecke der Werbung sowie der Markt- oder Meinungsforschung.