From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752326AbcBBDQt (ORCPT ); Mon, 1 Feb 2016 22:16:49 -0500 Received: from helcar.hengli.com.au ([209.40.204.226]:52965 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751728AbcBBDQq (ORCPT ); Mon, 1 Feb 2016 22:16:46 -0500 Date: Tue, 2 Feb 2016 11:16:16 +0800 From: Herbert Xu To: Andre Przywara Cc: Maxime Ripard , Chen-Yu Tsai , linux-sunxi@googlegroups.com, Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "David S . Miller" , linux-crypto@vger.kernel.org Subject: Re: [PATCH 02/11] crypto: sunxi-ss: prevent compilation on 64-bit Message-ID: <20160202031616.GA16987@gondor.apana.org.au> References: <1454348370-3816-1-git-send-email-andre.przywara@arm.com> <1454348370-3816-3-git-send-email-andre.przywara@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1454348370-3816-3-git-send-email-andre.przywara@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 01, 2016 at 05:39:21PM +0000, Andre Przywara wrote: > The driver for the sunxi-ss crypto engine is not entirely 64-bit safe, > compilation on arm64 spits some warnings. > The proper fix was deemed to involved [1], so since 64-bit SoCs won't > have this IP block we just disable this driver for 64-bit. > > [1]: http://lists.infradead.org/pipermail/linux-arm-kernel/2016-January/399988.html > (and the reply) > > Signed-off-by: Andre Przywara I still use COMPILE_TEST to test compile these drivers. So while I don't have a problem with this patch per se, please continue to ensure that it doesn't generate warnings on 64-bit platforms. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt