From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964919AbcBDBtd (ORCPT ); Wed, 3 Feb 2016 20:49:33 -0500 Received: from mail-pf0-f175.google.com ([209.85.192.175]:33874 "EHLO mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755760AbcBDBtb (ORCPT ); Wed, 3 Feb 2016 20:49:31 -0500 Date: Thu, 4 Feb 2016 07:19:27 +0530 From: Viresh Kumar To: Saravana Kannan Cc: Rafael Wysocki , juri.lelli@arm.com, linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, peterz@infradead.org, mturquette@baylibre.com, steve.muckle@linaro.org, vincent.guittot@linaro.org, morten.rasmussen@arm.com, dietmar.eggemann@arm.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 5/7] cpufreq: Merge cpufreq_offline_prepare/finish routines Message-ID: <20160204014927.GL3469@vireshk> References: <5e84719b5475f79602e95af524e66e8927a85bc9.1454507872.git.viresh.kumar@linaro.org> <56B26154.9010000@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56B26154.9010000@codeaurora.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03-02-16, 12:21, Saravana Kannan wrote: > On 02/03/2016 06:02 AM, Viresh Kumar wrote: > >The offline routine was separated into two halves earlier by > >'commit 1aee40ac9c86 ("cpufreq: Invoke __cpufreq_remove_dev_finish() > >after releasing cpu_hotplug.lock");. > > > >And the reasons cited were, race issues between accessing policy's sysfs > >files and policy kobject's cleanup. > > > >That race isn't valid anymore, as we don't remove the policy & its > >kobject completely on hotplugs, but do that from ->remove() callback of > >subsys framework. > > > >These two routines can be merged back now. > > > >This is a preparatory step for the next patch, that will enforce > >policy->rwsem lock around __cpufreq_governor() routines STOP/EXIT > >sequence. > > Is this stale text? Seems like this is now done in the *previous* patch? No, the previous patch has fixed a single location only. The next patch tried to fix others as well. -- viresh