From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965392AbcBDOS0 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 4 Feb 2016 09:18:26 -0500
Received: from smtprelay0053.hostedemail.com ([216.40.44.53]:34286 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1757557AbcBDOSG (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 4 Feb 2016 09:18:06 -0500
X-Session-Marker: 726F737465647440676F6F646D69732E6F7267
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:966:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1538:1566:1593:1594:1711:1714:1730:1747:1777:1792:2196:2199:2393:2553:2559:2562:2693:3138:3139:3140:3141:3142:3622:3867:3870:3872:4385:5007:6261:7875:8531:8660:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12438:12517:12519:12740:13069:13148:13230:13311:13357:14659:21080:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none
X-HE-Tag: tail04_4648321f11a16
X-Filterd-Recvd-Size: 1669
Date: Thu, 4 Feb 2016 09:18:01 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Petr Mladek <pmladek@suse.com>
Cc: Jessica Yu <jeyu@redhat.com>, Josh Poimboeuf <jpoimboe@redhat.com>,
        Seth Jennings <sjenning@redhat.com>, Jiri Kosina <jikos@kernel.org>,
        Vojtech Pavlik <vojtech@suse.com>, Miroslav Benes <mbenes@suse.cz>,
        Rusty Russell <rusty@rustcorp.com.au>, Ingo Molnar <mingo@redhat.com>,
        live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] ftrace/module: remove ftrace module notifier
Message-ID: <20160204091801.1ca8f81e@gandalf.local.home>
In-Reply-To: <20160204132751.GY3305@pathway.suse.cz>
References: <1454375856-27757-1-git-send-email-jeyu@redhat.com>
	<1454375856-27757-2-git-send-email-jeyu@redhat.com>
	<20160204132751.GY3305@pathway.suse.cz>
X-Mailer: Claws Mail 3.13.1 (GTK+ 2.24.29; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 4 Feb 2016 14:27:51 +0100
Petr Mladek <pmladek@suse.com> wrote:


> > +	ftrace_module_enable(mod);
> >  	blocking_notifier_call_chain(&module_notify_list,
> >  				     MODULE_STATE_COMING, mod);
> >  	return 0;  
> 
> Also we need to call ftrace_release_mod() in bug_cleanup:
> goto target in load_module(). Otherwise, it will stay
> enabled when, e.g. parse_args() fails.

Look farther down (after free_module:), it's already there.

-- Steve