From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966068AbcBDQbH (ORCPT ); Thu, 4 Feb 2016 11:31:07 -0500 Received: from foss.arm.com ([217.140.101.70]:43180 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964869AbcBDQbF (ORCPT ); Thu, 4 Feb 2016 11:31:05 -0500 Date: Thu, 4 Feb 2016 16:31:02 +0000 From: Will Deacon To: fu.wei@linaro.org Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, wim@iguana.be, linux@roeck-us.net, corbet@lwn.net, catalin.marinas@arm.com, Suravee.Suthikulpanit@amd.com, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linaro-acpi@lists.linaro.org, rruigrok@codeaurora.org, harba@codeaurora.org, cov@codeaurora.org, timur@codeaurora.org, dyoung@redhat.com, panand@redhat.com, graeme.gregory@linaro.org, al.stone@linaro.org, hanjun.guo@linaro.org, jcm@redhat.com, arnd@arndb.de, leo.duran@amd.com, sudeep.holla@arm.com Subject: Re: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver Message-ID: <20160204163101.GH17257@arm.com> References: <1454519923-25230-1-git-send-email-fu.wei@linaro.org> <1454519923-25230-5-git-send-email-fu.wei@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1454519923-25230-5-git-send-email-fu.wei@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 04, 2016 at 01:18:42AM +0800, fu.wei@linaro.org wrote: > +static int sbsa_gwdt_keepalive(struct watchdog_device *wdd) > +{ > + struct sbsa_gwdt *gwdt = to_sbsa_gwdt(wdd); > + > + /* > + * Writing WRR for an explicit watchdog refresh. > + * You can write anyting(like 0xc0ffee). > + */ > + writel(0xc0ffee, gwdt->refresh_base + SBSA_GWDT_WRR); > + > + return 0; > +} You might get in trouble for that. 0xd09f00d is probably less poisonous. http://www.petpoisonhelpline.com/poison/caffeine/ Will