From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757448AbcBDXI2 (ORCPT ); Thu, 4 Feb 2016 18:08:28 -0500 Received: from mail.kernel.org ([198.145.29.136]:60689 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757377AbcBDXIW (ORCPT ); Thu, 4 Feb 2016 18:08:22 -0500 Date: Thu, 4 Feb 2016 17:08:14 -0600 From: Rob Herring To: Andy Yan Cc: arnd@arndb.de, john.stultz@linaro.org, moritz.fischer@ettus.com, matthias.bgg@gmail.com, galak@codeaurora.org, ijc+devicetree@hellion.org.uk, catalin.marinas@arm.com, heiko@sntech.de, sre@kernel.org, dbaryshkov@gmail.com, alexandre.belloni@free-electrons.com, jun.nie@linaro.org, pawel.moll@arm.com, will.deacon@arm.com, linux-rockchip@lists.infradead.org, wxt@rock-chips.com, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux@arm.linux.org.uk, mbrugger@suse.com, linux-arm-kernel@lists.infradead.org, lorenzo.pieralisi@arm.com, linux-kernel@vger.kernel.org, richard@nod.at, dwmw2@infradead.org, mark.rutland@arm.com Subject: Re: [PATCH v3 1/4] dt-bindings: power: reset: add document for reboot-mode driver Message-ID: <20160204230814.GA4847@rob-hp-laptop> References: <1454406981-4692-1-git-send-email-andy.yan@rock-chips.com> <1454407151-4751-1-git-send-email-andy.yan@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1454407151-4751-1-git-send-email-andy.yan@rock-chips.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 02, 2016 at 05:59:11PM +0800, Andy Yan wrote: > add device tree bindings document for reboot-mode driver > > Signed-off-by: Andy Yan > > --- > > Changes in v3: > - descirbe all reboot mode as properity instead of subnode > > Changes in v2: None > Changes in v1: None > > .../bindings/power/reset/reboot-mode.txt | 26 ++++++++++++++++ > .../bindings/power/reset/syscon-reboot-mode.txt | 36 ++++++++++++++++++++++ > 2 files changed, 62 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/reset/reboot-mode.txt > create mode 100644 Documentation/devicetree/bindings/power/reset/syscon-reboot-mode.txt > > diff --git a/Documentation/devicetree/bindings/power/reset/reboot-mode.txt b/Documentation/devicetree/bindings/power/reset/reboot-mode.txt > new file mode 100644 > index 0000000..517080f > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/reset/reboot-mode.txt > @@ -0,0 +1,26 @@ > +Generic reboot mode core map driver > + > +This driver get reboot mode arguments and call the write > +interface to stores the magic value in special register > +or ram . Then the bootloader can read it and take different > +action according the argument stored. > + > +All mode properties are vendor specific, it is a indication to tell The values should be vendor specific. The property names should not. We can allow vendor specific ones, but we need to have a common set. > +the bootloder what to do when the system reboot, and should be named > +as mode-xxx = (xxx is mode name). > + > +- mode-normal: Normal reboot mode, system reboot with command "reboot". > +- mode-recovery: Android Recovery mode, it is a mode to format the device or update a new image. > +- mode-fastboot: Android fastboot mode, it's a mode to re-flash partitions on the device. > +- mode-loader: A bootloader mode, it's a mode used to download image on Rockchip platform, > + usually used in development. > +- mode-maskrom: It's a mode to download bootloader on Rockchip platform. > + > +Example: > + reboot-mode { > + mode-normal = ; > + mode-recovery = ; > + mode-fastboot = ; I tend to agree with John on calling this mode-bootloader. OTOH, fastboot is more specific about what the mode is. The name in DT and the userspace name don't necessarily have to be the same. > + mode-loader = ; This one needs a better name. Maybe it should be 'rockchip,mode-loader' as it is vendor specific. Either way, loader is vague. Perhaps rockchip,mode-bl-download? > + mode-maskrom = ; I think this should be "mode-rom-download". > + } > diff --git a/Documentation/devicetree/bindings/power/reset/syscon-reboot-mode.txt b/Documentation/devicetree/bindings/power/reset/syscon-reboot-mode.txt > new file mode 100644 > index 0000000..923c82b > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/reset/syscon-reboot-mode.txt > @@ -0,0 +1,36 @@ > +SYSCON reboot mode driver > + > +This driver get reboot mode magic value form reboot-mode driver > +and stores it in a SYSCON mapped register. Then the bootloader > +can read it and take different action according to the magic > +value stored. > + > +This DT node should be represented as a sub-node of a "syscon", "simple-mfd" > +node. Whether or not it is a simple-mfd or not depends on the syscon node. > + > +Required properties: > +- compatible: should be "syscon-reboot-mode" > +- offset: offset in the register map for the storage register (in bytes) > + > +Optional properity: > +- mask: the mask bits of the mode magic value, default set to 0xffffffff if missing. > + > +The rest of the properties should follow the generic reboot-mode discription > +found in reboot-mode.txt > + > +Example: > + pmu: pmu@20004000 { > + compatible = "rockchip,rk3066-pmu", "syscon", "simple-mfd"; > + reg = <0x20004000 0x100>; > + > + reboot-mode { > + compatible = "syscon-reboot-mode"; > + offset = <0x40>; > + mode-normal = ; > + mode-recovery = ; > + mode-fastboot = ; > + mode-loader = ; > + mode-maskrom = ; > + > + }; > + }; > -- > 1.9.1 > > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html