From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753427AbcBEOko (ORCPT ); Fri, 5 Feb 2016 09:40:44 -0500 Received: from smtprelay0083.hostedemail.com ([216.40.44.83]:37489 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750729AbcBEOkn (ORCPT ); Fri, 5 Feb 2016 09:40:43 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::,RULES_HIT:41:355:379:421:541:599:800:960:967:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2525:2553:2565:2682:2685:2736:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3871:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:6261:7514:7875:7903:8660:9025:9040:10004:10400:10848:10967:11026:11232:11658:11914:12043:12296:12438:12517:12519:12663:12740:13069:13148:13230:13311:13357:14096:14097:14659:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: actor55_232f1d6886463 X-Filterd-Recvd-Size: 2455 Date: Fri, 5 Feb 2016 09:40:40 -0500 From: Steven Rostedt To: Dmitry Safonov <0x7f454c46@gmail.com> Cc: mingo@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [RFC] trace_irqsoff: remove redundant reset per-CPU buff Message-ID: <20160205094040.2eb15c51@gandalf.local.home> In-Reply-To: References: <1445278226-16187-1-git-send-email-0x7f454c46@gmail.com> <20160204214045.1d6c2893@grimm.local.home> X-Mailer: Claws Mail 3.13.1 (GTK+ 2.24.29; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 5 Feb 2016 14:52:53 +0300 Dmitry Safonov <0x7f454c46@gmail.com> wrote: > 2016-02-05 5:40 GMT+03:00 Steven Rostedt : > > On Mon, 19 Oct 2015 21:10:26 +0300 > > Dmitry Safonov <0x7f454c46@gmail.com> wrote: > > > >> There is no reason to do it twice: from commit b6f11df26fdc28 > >> ("trace: Call tracing_reset_online_cpus before tracer->init()") > >> resetting of per-CPU buffers done before tracer->init() call. > >> > >> tracer->init() calls {irqs,preempt,preemptirqs}off_tracer_init() and it > >> calls __irqsoff_tracer_init(), which resets per-CPU ringbuffer second > >> time. > >> It's slowpath, but anyway. > > > > Bah, I said I'd look at this and I did. But never added it to my queue. > > It's not a big deal as this is the slow path but it makes sense. I knew > > there was a patch from you to get but saw the TP_ARGS redefining patch > > and thought that was it. > > Thanks, Steve! > Yeah, I know it may take time to get to unimportant patches > that are also mostly cleanups. > Don't worry, please, take a glance when you'll have time on these > small also not important cleanings (I'm fine if you'll drop them all): > https://lkml.org/lkml/2015/11/20/290 > https://lkml.org/lkml/2015/11/20/291 > https://lkml.org/lkml/2015/10/30/580 I'm slowing going through my INBOX (doing clean up to see what I missed). I'm currently at 11/10. I marked your 10/30 one already as a "go back and look at later". -- Steve