From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752608AbcBELOM (ORCPT ); Fri, 5 Feb 2016 06:14:12 -0500 Received: from down.free-electrons.com ([37.187.137.238]:52879 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751464AbcBELOK (ORCPT ); Fri, 5 Feb 2016 06:14:10 -0500 Date: Fri, 5 Feb 2016 12:14:08 +0100 From: Maxime Ripard To: Krzysztof Adamski Cc: Jean-Francois Moine , inus Walleij , Chen-Yu Tsai , Hans de Goede , Lee Jones , Rob Herring , Jens Kuske , Fabian Frederick , Vishnu Patekar , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v3 1/5] clk: sunxi: Add apb0 gates for H3 Message-ID: <20160205111408.GB31506@lukather> References: <1454542430-16572-1-git-send-email-k@japko.eu> <1454542430-16572-2-git-send-email-k@japko.eu> <20160204154752.4df7808be3364a98c496c030@free.fr> <20160204205602.GC12071@box2.japko.eu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yNb1oOkm5a9FJOVX" Content-Disposition: inline In-Reply-To: <20160204205602.GC12071@box2.japko.eu> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --yNb1oOkm5a9FJOVX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Feb 04, 2016 at 09:56:02PM +0100, Krzysztof Adamski wrote: > On Thu, Feb 04, 2016 at 03:47:52PM +0100, Jean-Francois Moine wrote: > >On Thu, 4 Feb 2016 00:33:46 +0100 > >Krzysztof Adamski wrote: > > > >>This patch adds support for APB0 in H3. It seems to be compatible with > >>earlier SOCs. apb0 gates controls R_ block peripherals (R_PIO, R_IR, > >>etc). > >> > >>Signed-off-by: Krzysztof Adamski > >>--- > >> Documentation/devicetree/bindings/clock/sunxi.txt | 1 + > >> drivers/clk/sunxi/clk-simple-gates.c | 2 ++ > >> 2 files changed, 3 insertions(+) > >> > >>diff --git a/Documentation/devicetree/bindings/clock/sunxi.txt b/Docume= ntation/devicetree/bindings/clock/sunxi.txt > >>index e59f57b..751c8b9f0 100644 > >>--- a/Documentation/devicetree/bindings/clock/sunxi.txt > >>+++ b/Documentation/devicetree/bindings/clock/sunxi.txt > >>@@ -45,6 +45,7 @@ Required properties: > >> "allwinner,sun6i-a31-apb0-gates-clk" - for the APB0 gates on A31 > >> "allwinner,sun7i-a20-apb0-gates-clk" - for the APB0 gates on A20 > >> "allwinner,sun8i-a23-apb0-gates-clk" - for the APB0 gates on A23 > >>+ "allwinner,sun8i-h3-apb0-gates-clk" - for the APB0 gates on H3 > >> "allwinner,sun9i-a80-apb0-gates-clk" - for the APB0 gates on A80 > >> "allwinner,sun4i-a10-apb1-clk" - for the APB1 clock > >> "allwinner,sun9i-a80-apb1-clk" - for the APB1 bus clock on A80 > >>diff --git a/drivers/clk/sunxi/clk-simple-gates.c b/drivers/clk/sunxi/c= lk-simple-gates.c > >>index f4da52b..6753c87 100644 > >>--- a/drivers/clk/sunxi/clk-simple-gates.c > >>+++ b/drivers/clk/sunxi/clk-simple-gates.c > >>@@ -130,6 +130,8 @@ CLK_OF_DECLARE(sun8i_a23_apb2, "allwinner,sun8i-a23= -apb2-gates-clk", > >> sunxi_simple_gates_init); > >> CLK_OF_DECLARE(sun8i_a33_ahb1, "allwinner,sun8i-a33-ahb1-gates-clk", > >> sunxi_simple_gates_init); > >>+CLK_OF_DECLARE(sun8i_h3_apb0, "allwinner,sun8i-h3-apb0-gates-clk", > >>+ sunxi_simple_gates_init); > >> CLK_OF_DECLARE(sun9i_a80_ahb0, "allwinner,sun9i-a80-ahb0-gates-clk", > >> sunxi_simple_gates_init); > >> CLK_OF_DECLARE(sun9i_a80_ahb1, "allwinner,sun9i-a80-ahb1-gates-clk", > > > >It seems that the other compatible strings are there for historical > >reasons. Why do you need a new one with such a specific name? > > > >It would have been more sensible to add a generic compatible string as > >"allwinner,apb-gates", letting the removal of the other strings for a > >later patch... >=20 > Seems like a good idea but is it possible to remove those binding in > separate patch? Yeah, you can (and should) do that as a separate patch, that can be part of the next iteration of this set. > I mean, wouldn't that, in theory, break ABI? Are such > patches accepted? It would, but it doesn't matter. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --yNb1oOkm5a9FJOVX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWtIQAAAoJEBx+YmzsjxAgbsUP+QHl1PQBLgAI0GrWorwlvjde 5t2l6/rM8UXeVMab7Bu5xciln9u5QkrSnVLXjWk/0ywwHAtI1hMnjdssvqs9Ijzt ahclzRCq3GhoXrNjMR0wRbtxjepCGzhqEMpHeLENUxkT90aORsdaleWl8p5o1g7r UXXQRtuGd9D4juS44kXsfgsqgWFak9Mwe+FDVbrAFZc/0jCuq+dcfwMfw5WqQfzU 1P/S8VPWLbd9ON7WjaArEDur4bfc9QxE9x4nEofkIMup3wOaSGOVTFI+e2OanO9l O6xkfIJtxbRkgHdD5L7Kj/pm4CdZS6G+GDzBnRNM49r1qRmXnC0RXvuOaXQhdoAs ECkS1gEzFXmzaf30L/UbI9ktePcF1RVrQAdzpqkyzzK14ij1MXCzSWJg4nUeTonU zYBZ2o+NwbLqz6ec6MSCzeByUwezoB4LJLJdBa6/Ms5jVix4RGirmwwkYrFk+/AM ai2RVMxBQoTPRhMS0GHAl27rdgS7+reTZem9zXp7VtjTSfRevbpXOsAcG9JJWEwn 9eKOqJPqepazWaeaXNicXOgYKPrQX1oFqQoSUTSWNTcCNh8yflxUmHWUBdArAhCN LuxqWBxJKBGl0vIhr2iDMcqP+SP0UiAhQ9Dx+7NCfeIpyvWX+zEkIfxLMdHaqVJ1 CWdbQoEBJ+q+PHZh8nVY =DyUL -----END PGP SIGNATURE----- --yNb1oOkm5a9FJOVX--