From: Bjorn Helgaas <helgaas@kernel.org>
To: "Shi, Yang" <yang.shi@linaro.org>
Cc: Mingkai.Hu@freescale.com, Minghuan.Lian@freescale.com,
bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linaro-kernel@lists.linaro.org, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH] PCI: layerscape: add ls2085a compatible
Date: Fri, 5 Feb 2016 16:25:25 -0600 [thread overview]
Message-ID: <20160205222525.GA16238@localhost> (raw)
In-Reply-To: <56B509E5.2050602@linaro.org>
On Fri, Feb 05, 2016 at 12:45:25PM -0800, Shi, Yang wrote:
> On 2/5/2016 12:38 PM, Bjorn Helgaas wrote:
> >[+cc Rob, et al]
> >
> >On Wed, Jan 27, 2016 at 09:32:05AM -0800, Yang Shi wrote:
> >>The layerscape PCI host driver needs recognize ls2085a compatible when using
> >>firmware with ls2085a compatible property, otherwise the PCI bus won't be
> >>detected even though ls2085a compatible is included by the dts.
> >>
> >>Signed-off-by: Yang Shi <yang.shi@linaro.org>
> >>---
> >> drivers/pci/host/pci-layerscape.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >>diff --git a/drivers/pci/host/pci-layerscape.c b/drivers/pci/host/pci-layerscape.c
> >>index 3923bed..c40d8b2 100644
> >>--- a/drivers/pci/host/pci-layerscape.c
> >>+++ b/drivers/pci/host/pci-layerscape.c
> >>@@ -203,6 +203,7 @@ static const struct of_device_id ls_pcie_of_match[] = {
> >> { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata },
> >> { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata },
> >> { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata },
> >>+ { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata },
> >
> >Hmm, "fsl,ls2085a-pcie" doesn't appear in
> >Documentation/devicetree/bindings/pci/.
> >
> >Aren't we supposed to add these strings to the bindings before or at
> >the same time we add them to drivers?
>
> The below patch will add it into dts and binding doc. I should
> mentioned this in the commit log.
>
> https://patchwork.kernel.org/patch/7767061/
OK. This is really annoying as a reviewer. To me, adding
"fsl,ls2085a-pcie" to:
- the binding in Documentation/devicetree/bindings/pci/layerscape-pci.txt
- the DT in arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
- the driver in drivers/pci/host/pci-layerscape.c
are all logically related, and it would make sense to have them all in
a single patch.
But whatever. I applied this to pci/host-layerscape for v4.6.
> >checkpatch doesn't complain though, so maybe I'm wrong about this.
> >
> >> { },
> >> };
> >> MODULE_DEVICE_TABLE(of, ls_pcie_of_match);
> >>--
> >>2.0.2
> >>
> >>--
> >>To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> >>the body of a message to majordomo@vger.kernel.org
> >>More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-02-05 22:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 17:32 [PATCH] PCI: layerscape: add ls2085a compatible Yang Shi
2016-01-27 18:05 ` Shi, Yang
2016-02-04 22:37 ` Bjorn Helgaas
2016-02-04 23:49 ` Shi, Yang
2016-02-05 5:36 ` Bhupesh Sharma
2016-02-05 6:07 ` Minghuan Lian
2016-02-05 15:54 ` Bjorn Helgaas
2016-02-05 19:36 ` Yang-Leo Li
2016-02-14 2:10 ` Shawn Guo
2016-02-05 20:38 ` Bjorn Helgaas
2016-02-05 20:45 ` Shi, Yang
2016-02-05 22:25 ` Bjorn Helgaas [this message]
2016-02-17 2:17 ` Mingkai Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160205222525.GA16238@localhost \
--to=helgaas@kernel.org \
--cc=Minghuan.Lian@freescale.com \
--cc=Mingkai.Hu@freescale.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=yang.shi@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).