From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756616AbcBIQu3 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 9 Feb 2016 11:50:29 -0500
Received: from mail-yw0-f177.google.com ([209.85.161.177]:33478 "EHLO
	mail-yw0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756483AbcBIQu0 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 9 Feb 2016 11:50:26 -0500
Date: Tue, 9 Feb 2016 11:50:24 -0500
From: Tejun Heo <tj@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <umgwanakikbuti@gmail.com>,
        Michal Hocko <mhocko@kernel.org>, Jiri Slaby <jslaby@suse.cz>,
        Thomas Gleixner <tglx@linutronix.de>, Petr Mladek <pmladek@suse.com>,
        Jan Kara <jack@suse.cz>, Ben Hutchings <ben@decadent.org.uk>,
        Sasha Levin <sasha.levin@oracle.com>, Shaohua Li <shli@fb.com>,
        LKML <linux-kernel@vger.kernel.org>, stable <stable@vger.kernel.org>,
        Daniel Bilik <daniel.bilik@neosystem.cz>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: Crashes with 874bbfe600a6 in 3.18.25
Message-ID: <20160209165024.GA3741@mtj.duckdns.org>
References: <1454518913.6148.15.camel@gmail.com>
 <20160203170652.GI14091@mtj.duckdns.org>
 <1454551217.3677.27.camel@gmail.com>
 <20160205164923.GC4401@htj.duckdns.org>
 <1454705231.3819.151.camel@gmail.com>
 <20160205205456.GG4401@htj.duckdns.org>
 <1454705989.3819.158.camel@gmail.com>
 <20160205210606.GH4401@htj.duckdns.org>
 <1455031885.3807.74.camel@gmail.com>
 <CA+55aFwQDMuieCNEh86GXKoCjj+B6aZBTt--y7sUCtqzLkPf5Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+55aFwQDMuieCNEh86GXKoCjj+B6aZBTt--y7sUCtqzLkPf5Q@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello,

On Tue, Feb 09, 2016 at 08:39:15AM -0800, Linus Torvalds wrote:
> > A niggling question remaining is when is it gonna be killed?
> 
> It probably should be killed sooner rather than later.
> 
> Just document that if you need something to run on a _particular_ cpu,
> you need to use "schedule_delayed_work_on()" and "add_timer_on()".

I'll queue a patch to put unbound work items on foreign cpus (maybe
every Nth to reduce perf impact).  Wanted to align it to rc1 and then
let it get tested during the devel cycle but missed this window.  It's
a bit late in devel cycle but we can still do it in this cycle.

> The proper fix was 176bed1de5bf, and 874bbfe6 was just wrong.

idk, not doing so is likely to cause subtle bugs which are difficult
to track down.  The problem with -stable is 874bbfe6 being backported
without the matching timer fix.  The right thing to do now probably is
reverting 874bbfe6 for -stable kernels which don't get the timer fix.

Thanks.

-- 
tejun