From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752733AbcBLOKT (ORCPT ); Fri, 12 Feb 2016 09:10:19 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:41476 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752447AbcBLOKR (ORCPT ); Fri, 12 Feb 2016 09:10:17 -0500 Date: Fri, 12 Feb 2016 15:10:09 +0100 From: Peter Zijlstra To: Steve Muckle Cc: "Rafael J. Wysocki" , "Rafael J. Wysocki" , Linux PM list , Linux Kernel Mailing List , Srinivas Pandruvada , Viresh Kumar , Juri Lelli , Thomas Gleixner Subject: Re: [PATCH 0/3] cpufreq: Replace timers with utilization update callbacks Message-ID: <20160212141009.GT6357@twins.programming.kicks-ass.net> References: <3071836.JbNxX8hU6x@vostro.rjw.lan> <56B93548.9090006@linaro.org> <5387313.xAhVpzgZCg@vostro.rjw.lan> <56BA8C29.4090905@linaro.org> <20160211115959.GI6357@twins.programming.kicks-ass.net> <56BCBF7C.2080404@linaro.org> <20160211173033.GP6357@twins.programming.kicks-ass.net> <56BCD864.6030207@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56BCD864.6030207@linaro.org> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 11, 2016 at 10:52:20AM -0800, Steve Muckle wrote: > On 02/11/2016 09:30 AM, Peter Zijlstra wrote: > >> My concern above is that pokes are guaranteed to keep occurring when > >> > there is only RT or DL activity so nothing breaks. > > > > The hook in their respective tick handler should ensure stuff is called > > sporadically and isn't stalled. > > But that's only true if the RT/DL tasks happen to be running when the > tick arrives right? > > Couldn't we have RT/DL activity which doesn't overlap with the tick? And > if no CFS tasks happen to be executing on that CPU, we'll never trigger > the cpufreq update. This could go on for an arbitrarily long time > depending on the periodicity of the work. Possible yes, but why do we care? Such a CPU would be so much idle that cpufreq doesn't matter one way or another, right?