* [PATCH] net: phy: spi_ks8995: include linux/gpio/consumer.h
@ 2016-02-12 10:42 Arnd Bergmann
2016-02-17 1:36 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2016-02-12 10:42 UTC (permalink / raw
To: David S . Miller
Cc: linux-arm-kernel, Arnd Bergmann, Helmut Buchsbaum,
Florian Fainelli, netdev, linux-kernel
The ks8995 phy driver just started using gpiod_* functions, which are
declared in linux/gpio/consumer.h, not linux/gpio.h, resulting in a
build failure in randconfig builds that do not have CONFIG_GPIOLIB
enabled:
drivers/net/phy/spi_ks8995.c: In function 'ks8995_probe':
drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration]
This changes the header inclusion so it builds in all configurations.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO")
---
drivers/net/phy/spi_ks8995.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy/spi_ks8995.c
index 5e7340f6b37c..b5d50d458728 100644
--- a/drivers/net/phy/spi_ks8995.c
+++ b/drivers/net/phy/spi_ks8995.c
@@ -18,8 +18,8 @@
#include <linux/module.h>
#include <linux/delay.h>
#include <linux/device.h>
+#include <linux/gpio/consumer.h>
#include <linux/of.h>
-#include <linux/gpio.h>
#include <linux/of_gpio.h>
#include <linux/spi/spi.h>
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: phy: spi_ks8995: include linux/gpio/consumer.h
2016-02-12 10:42 [PATCH] net: phy: spi_ks8995: include linux/gpio/consumer.h Arnd Bergmann
@ 2016-02-17 1:36 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-02-17 1:36 UTC (permalink / raw
To: arnd; +Cc: linux-arm-kernel, helmut.buchsbaum, f.fainelli, netdev,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Date: Fri, 12 Feb 2016 11:42:34 +0100
> The ks8995 phy driver just started using gpiod_* functions, which are
> declared in linux/gpio/consumer.h, not linux/gpio.h, resulting in a
> build failure in randconfig builds that do not have CONFIG_GPIOLIB
> enabled:
>
> drivers/net/phy/spi_ks8995.c: In function 'ks8995_probe':
> drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration]
>
> This changes the header inclusion so it builds in all configurations.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO")
Applied, thanks Arnd.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-17 1:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-12 10:42 [PATCH] net: phy: spi_ks8995: include linux/gpio/consumer.h Arnd Bergmann
2016-02-17 1:36 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).