From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161195AbcBQKmF (ORCPT ); Wed, 17 Feb 2016 05:42:05 -0500 Received: from www262.sakura.ne.jp ([202.181.97.72]:31418 "EHLO www262.sakura.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030266AbcBQKmD (ORCPT ); Wed, 17 Feb 2016 05:42:03 -0500 To: mhocko@kernel.org, akpm@linux-foundation.org Cc: rientjes@google.com, mgorman@suse.de, oleg@redhat.com, torvalds@linux-foundation.org, hughd@google.com, andrea@kernel.org, riel@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/5] oom, oom_reaper: disable oom_reaper for From: Tetsuo Handa References: <1454505240-23446-1-git-send-email-mhocko@kernel.org> <1454505240-23446-6-git-send-email-mhocko@kernel.org> <20160217094855.GC29196@dhcp22.suse.cz> In-Reply-To: <20160217094855.GC29196@dhcp22.suse.cz> Message-Id: <201602171941.EHF67212.HOFSFFJMtOOQLV@I-love.SAKURA.ne.jp> X-Mailer: Winbiff [Version 2.51 PL2] X-Accept-Language: ja,en,zh Date: Wed, 17 Feb 2016 19:41:53 +0900 Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Michal Hocko wrote: > Hi Andrew, > although this can be folded into patch 5 > (mm-oom_reaper-implement-oom-victims-queuing.patch) I think it would be > better to have it separate and revert after we sort out the proper > oom_kill_allocating_task behavior or handle exclusion at oom_reaper > level. What a rough workaround. sysctl_oom_kill_allocating_task == 1 does not always mean we must skip OOM reaper, for OOM-unkillable callers take sysctl_oom_kill_allocating_task == 0 path. I've just posted a patchset which allows you to merge the OOM reaper without correcting problems found in "[PATCH 3/5] oom: clear TIF_MEMDIE after oom_reaper managed to unmap the address space" and "[PATCH 5/5] mm, oom_reaper: implement OOM victims queuing".