From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Amit Pundir <amit.pundir@linaro.org>,
Kalle Valo <kvalo@codeaurora.org>,
David S Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Jeffrey Hugo <jeffrey.l.hugo@gmail.com>,
John Stultz <john.stultz@linaro.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
Konrad Dybcio <konradybcio@gmail.com>,
ath10k@lists.infradead.org, devicetree@vger.kernel.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ath10k: Introduce a devicetree quirk to skip host cap QMI requests
Date: Thu, 29 Oct 2020 08:40:17 -0500 [thread overview]
Message-ID: <20201029134017.GA807@yoga> (raw)
In-Reply-To: <20200929190817.GA968845@bogus>
On Tue 29 Sep 14:08 CDT 2020, Rob Herring wrote:
> On Fri, Sep 25, 2020 at 11:59:41PM +0530, Amit Pundir wrote:
> > There are firmware versions which do not support host capability
> > QMI request. We suspect either the host cap is not implemented or
> > there may be firmware specific issues, but apparently there seem
> > to be a generation of firmware that has this particular behavior.
> >
> > For example, firmware build on Xiaomi Poco F1 (sdm845) phone:
> > "QC_IMAGE_VERSION_STRING=WLAN.HL.2.0.c3-00257-QCAHLSWMTPLZ-1"
> >
> > If we do not skip the host cap QMI request on Poco F1, then we
> > get a QMI_ERR_MALFORMED_MSG_V01 error message in the
> > ath10k_qmi_host_cap_send_sync(). But this error message is not
> > fatal to the firmware nor to the ath10k driver and we can still
> > bring up the WiFi services successfully if we just ignore it.
> >
> > Hence introducing this DeviceTree quirk to skip host capability
> > QMI request for the firmware versions which do not support this
> > feature.
>
> So if you change the WiFi firmware, you may force a DT change too. Those
> are pretty independent things otherwise.
>
Yes and that's not good. But I looked at somehow derive this from
firmware version numbers etc and it's not working out, so I'm out of
ideas for alternatives.
> Why can't you just always ignore this error? If you can't deal with this
> entirely in the driver, then it should be part of the WiFi firmware so
> it's always in sync.
>
Unfortunately the firmware versions I've hit this problem on has gone
belly up when receiving this request, that's why I asked Amit to add a
flag to skip it.
That said, in the devices I've hit this I've managed to get newer
firmware working, which doesn't have either problem.
Regards,
Bjorn
next prev parent reply other threads:[~2020-10-29 13:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 18:29 [PATCH] ath10k: Introduce a devicetree quirk to skip host cap QMI requests Amit Pundir
2020-09-26 0:00 ` Bjorn Andersson
2020-09-29 19:08 ` Rob Herring
2020-09-30 11:09 ` Amit Pundir
2020-10-29 13:40 ` Bjorn Andersson [this message]
2020-11-03 7:48 ` Amit Pundir
2020-11-24 17:51 ` Bjorn Andersson
2020-12-07 16:55 ` Kalle Valo
2021-02-02 11:11 ` Amit Pundir
2021-02-08 17:21 ` Kalle Valo
2021-02-08 17:48 ` Bjorn Andersson
2021-02-09 8:10 ` Kalle Valo
2021-05-20 11:47 ` Amit Pundir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029134017.GA807@yoga \
--to=bjorn.andersson@linaro.org \
--cc=amit.pundir@linaro.org \
--cc=ath10k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=john.stultz@linaro.org \
--cc=konradybcio@gmail.com \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).