* [PATCH] mfd: ABX500_CORE should depend on ARCH_U8500
@ 2021-03-16 13:37 Geert Uytterhoeven
2021-03-20 12:01 ` Linus Walleij
2021-03-23 9:06 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2021-03-16 13:37 UTC (permalink / raw
To: Lee Jones, Linus Walleij
Cc: linux-arm-kernel, linux-kernel, Geert Uytterhoeven
The ST-Ericsson ABX500 Mixed Signal IC family chips are only present on
ST-Ericsson U8500 Series platforms. Hence add a dependency on
ARCH_U8500, to prevent asking the user about this driver when
configuring a kernel without U8500 support.
Also, merely enabling CONFIG_COMPILE_TEST should not enable additional
code, and thus should not enable this driver by default.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/mfd/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 21a131d4e7bb9eca..d07e8cf9328612c5 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -1235,7 +1235,8 @@ config MFD_SC27XX_PMIC
config ABX500_CORE
bool "ST-Ericsson ABX500 Mixed Signal Circuit register functions"
- default y if ARCH_U8500 || COMPILE_TEST
+ depends on ARCH_U8500 || COMPILE_TEST
+ default y if ARCH_U8500
help
Say yes here if you have the ABX500 Mixed Signal IC family
chips. This core driver expose register access functions.
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: ABX500_CORE should depend on ARCH_U8500
2021-03-16 13:37 [PATCH] mfd: ABX500_CORE should depend on ARCH_U8500 Geert Uytterhoeven
@ 2021-03-20 12:01 ` Linus Walleij
2021-03-23 9:06 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2021-03-20 12:01 UTC (permalink / raw
To: Geert Uytterhoeven; +Cc: Lee Jones, Linux ARM, linux-kernel@vger.kernel.org
On Tue, Mar 16, 2021 at 2:37 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> The ST-Ericsson ABX500 Mixed Signal IC family chips are only present on
> ST-Ericsson U8500 Series platforms. Hence add a dependency on
> ARCH_U8500, to prevent asking the user about this driver when
> configuring a kernel without U8500 support.
>
> Also, merely enabling CONFIG_COMPILE_TEST should not enable additional
> code, and thus should not enable this driver by default.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Very nice. Good catch!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: ABX500_CORE should depend on ARCH_U8500
2021-03-16 13:37 [PATCH] mfd: ABX500_CORE should depend on ARCH_U8500 Geert Uytterhoeven
2021-03-20 12:01 ` Linus Walleij
@ 2021-03-23 9:06 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2021-03-23 9:06 UTC (permalink / raw
To: Geert Uytterhoeven; +Cc: Linus Walleij, linux-arm-kernel, linux-kernel
On Tue, 16 Mar 2021, Geert Uytterhoeven wrote:
> The ST-Ericsson ABX500 Mixed Signal IC family chips are only present on
> ST-Ericsson U8500 Series platforms. Hence add a dependency on
> ARCH_U8500, to prevent asking the user about this driver when
> configuring a kernel without U8500 support.
>
> Also, merely enabling CONFIG_COMPILE_TEST should not enable additional
> code, and thus should not enable this driver by default.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/mfd/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-23 9:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-16 13:37 [PATCH] mfd: ABX500_CORE should depend on ARCH_U8500 Geert Uytterhoeven
2021-03-20 12:01 ` Linus Walleij
2021-03-23 9:06 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).