* [PATCH 0/3] arm64: dts: meson: misc ODROID-N2/N2+ changes
@ 2021-03-29 16:12 Christian Hewitt
2021-03-29 16:12 ` [PATCH 1/3] arm64: dts: meson: remove extra tab from ODROID N2/N2+ ext_mdio node Christian Hewitt
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Christian Hewitt @ 2021-03-29 16:12 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Kevin Hilman, devicetree,
linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Christian Hewitt
This series cleans-up and submits some minor patches used in HardKernel
Linux 5.10 and 5.11 images for the ODROID N2/N2+, and fixes a stray tab.
Christian Hewitt (1):
arm64: dts: meson: remove extra tab from ODROID N2/N2+ ext_mdio node
Hyeonki Hong (2):
arm64: dts: meson: add saradc node to ODROID N2/N2+
arm64: dts: meson: add GPIO line names to ODROID N2/N2+
.../dts/amlogic/meson-g12b-odroid-n2.dtsi | 51 ++++++++++++++++++-
1 file changed, 50 insertions(+), 1 deletion(-)
--
2.17.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/3] arm64: dts: meson: remove extra tab from ODROID N2/N2+ ext_mdio node
2021-03-29 16:12 [PATCH 0/3] arm64: dts: meson: misc ODROID-N2/N2+ changes Christian Hewitt
@ 2021-03-29 16:12 ` Christian Hewitt
2021-03-30 15:22 ` Neil Armstrong
2021-04-05 20:54 ` Martin Blumenstingl
2021-03-29 16:12 ` [PATCH 2/3] arm64: dts: meson: add saradc node to ODROID N2/N2+ Christian Hewitt
2021-03-29 16:12 ` [PATCH 3/3] arm64: dts: meson: add GPIO line names " Christian Hewitt
2 siblings, 2 replies; 10+ messages in thread
From: Christian Hewitt @ 2021-03-29 16:12 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Kevin Hilman, devicetree,
linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Christian Hewitt
Remove an extra tab from the ext_mdio node in the ODROID N2/N2+ common
dtsi file.
Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
---
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
index 58ce569b2ace..2f8d574c30c0 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
@@ -410,7 +410,7 @@
&ext_mdio {
external_phy: ethernet-phy@0 {
- /* Realtek RTL8211F (0x001cc916) */
+ /* Realtek RTL8211F (0x001cc916) */
reg = <0>;
max-speed = <1000>;
--
2.17.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/3] arm64: dts: meson: add saradc node to ODROID N2/N2+
2021-03-29 16:12 [PATCH 0/3] arm64: dts: meson: misc ODROID-N2/N2+ changes Christian Hewitt
2021-03-29 16:12 ` [PATCH 1/3] arm64: dts: meson: remove extra tab from ODROID N2/N2+ ext_mdio node Christian Hewitt
@ 2021-03-29 16:12 ` Christian Hewitt
2021-03-30 15:23 ` Neil Armstrong
2021-04-05 20:56 ` Martin Blumenstingl
2021-03-29 16:12 ` [PATCH 3/3] arm64: dts: meson: add GPIO line names " Christian Hewitt
2 siblings, 2 replies; 10+ messages in thread
From: Christian Hewitt @ 2021-03-29 16:12 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Kevin Hilman, devicetree,
linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Christian Hewitt, Hyeonki Hong
From: Hyeonki Hong <hhk7734@gmail.com>
Add the meson saradc node to the ODROID N2/N2+ common dtsi.
Signed-off-by: Hyeonki Hong <hhk7734@gmail.com>
---
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
index 2f8d574c30c0..139c12cf9f66 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
@@ -508,6 +508,10 @@
status = "okay";
};
+&saradc {
+ status = "okay";
+};
+
/* SD card */
&sd_emmc_b {
status = "okay";
--
2.17.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 3/3] arm64: dts: meson: add GPIO line names to ODROID N2/N2+
2021-03-29 16:12 [PATCH 0/3] arm64: dts: meson: misc ODROID-N2/N2+ changes Christian Hewitt
2021-03-29 16:12 ` [PATCH 1/3] arm64: dts: meson: remove extra tab from ODROID N2/N2+ ext_mdio node Christian Hewitt
2021-03-29 16:12 ` [PATCH 2/3] arm64: dts: meson: add saradc node to ODROID N2/N2+ Christian Hewitt
@ 2021-03-29 16:12 ` Christian Hewitt
2021-03-30 15:23 ` Neil Armstrong
2021-03-31 21:32 ` Kevin Hilman
2 siblings, 2 replies; 10+ messages in thread
From: Christian Hewitt @ 2021-03-29 16:12 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Kevin Hilman, devicetree,
linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Christian Hewitt, Hyeonki Hong
From: Hyeonki Hong <hhk7734@gmail.com>
Add GPIO line-name identifiers to the ODROID N2/N2+ common dtsi.
Signed-off-by: Hyeonki Hong <hhk7734@gmail.com>
---
.../dts/amlogic/meson-g12b-odroid-n2.dtsi | 45 +++++++++++++++++++
1 file changed, 45 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
index 139c12cf9f66..4489715fc4f3 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
@@ -446,6 +446,51 @@
};
&gpio {
+ gpio-line-names =
+ /* GPIOZ */
+ "", "", "", "", "", "", "", "",
+ "", "", "", "", "", "", "", "",
+ /* GPIOH */
+ "", "", "", "", "", "", "", "",
+ "",
+ /* BOOT */
+ "", "", "", "", "", "", "", "",
+ "", "", "", "", "", "", "", "",
+ /* GPIOC */
+ "", "", "", "", "", "", "", "",
+ /* GPIOA */
+ "PIN_44", /* GPIOA_0 */
+ "PIN_46", /* GPIOA_1 */
+ "PIN_45", /* GPIOA_2 */
+ "PIN_47", /* GPIOA_3 */
+ "PIN_26", /* GPIOA_4 */
+ "", "", "", "", "", "",
+ "PIN_42", /* GPIOA_11 */
+ "PIN_32", /* GPIOA_12 */
+ "PIN_7", /* GPIOA_13 */
+ "PIN_27", /* GPIOA_14 */
+ "PIN_28", /* GPIOA_15 */
+ /* GPIOX */
+ "PIN_16", /* GPIOX_0 */
+ "PIN_18", /* GPIOX_1 */
+ "PIN_22", /* GPIOX_2 */
+ "PIN_11", /* GPIOX_3 */
+ "PIN_13", /* GPIOX_4 */
+ "PIN_33", /* GPIOX_5 */
+ "PIN_35", /* GPIOX_6 */
+ "PIN_15", /* GPIOX_7 */
+ "PIN_19", /* GPIOX_8 */
+ "PIN_21", /* GPIOX_9 */
+ "PIN_24", /* GPIOX_10 */
+ "PIN_23", /* GPIOX_11 */
+ "PIN_8", /* GPIOX_12 */
+ "PIN_10", /* GPIOX_13 */
+ "PIN_29", /* GPIOX_14 */
+ "PIN_31", /* GPIOX_15 */
+ "PIN_12", /* GPIOX_16 */
+ "PIN_3", /* GPIOX_17 */
+ "PIN_5", /* GPIOX_18 */
+ "PIN_36"; /* GPIOX_19 */
/*
* WARNING: The USB Hub on the Odroid-N2 needs a reset signal
* to be turned high in order to be detected by the USB Controller
--
2.17.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] arm64: dts: meson: remove extra tab from ODROID N2/N2+ ext_mdio node
2021-03-29 16:12 ` [PATCH 1/3] arm64: dts: meson: remove extra tab from ODROID N2/N2+ ext_mdio node Christian Hewitt
@ 2021-03-30 15:22 ` Neil Armstrong
2021-04-05 20:54 ` Martin Blumenstingl
1 sibling, 0 replies; 10+ messages in thread
From: Neil Armstrong @ 2021-03-30 15:22 UTC (permalink / raw)
To: Christian Hewitt, Rob Herring, Mark Rutland, Kevin Hilman,
devicetree, linux-arm-kernel, linux-amlogic, linux-kernel
On 29/03/2021 18:12, Christian Hewitt wrote:
> Remove an extra tab from the ext_mdio node in the ODROID N2/N2+ common
> dtsi file.
>
> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> index 58ce569b2ace..2f8d574c30c0 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> @@ -410,7 +410,7 @@
>
> &ext_mdio {
> external_phy: ethernet-phy@0 {
> - /* Realtek RTL8211F (0x001cc916) */
> + /* Realtek RTL8211F (0x001cc916) */
> reg = <0>;
> max-speed = <1000>;
>
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/3] arm64: dts: meson: add saradc node to ODROID N2/N2+
2021-03-29 16:12 ` [PATCH 2/3] arm64: dts: meson: add saradc node to ODROID N2/N2+ Christian Hewitt
@ 2021-03-30 15:23 ` Neil Armstrong
2021-04-05 20:56 ` Martin Blumenstingl
1 sibling, 0 replies; 10+ messages in thread
From: Neil Armstrong @ 2021-03-30 15:23 UTC (permalink / raw)
To: Christian Hewitt, Rob Herring, Mark Rutland, Kevin Hilman,
devicetree, linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Hyeonki Hong
Hi,
On 29/03/2021 18:12, Christian Hewitt wrote:
> From: Hyeonki Hong <hhk7734@gmail.com>
>
> Add the meson saradc node to the ODROID N2/N2+ common dtsi.
Not sure why this is needed, does it fix something ?
Neil
>
> Signed-off-by: Hyeonki Hong <hhk7734@gmail.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> index 2f8d574c30c0..139c12cf9f66 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> @@ -508,6 +508,10 @@
> status = "okay";
> };
>
> +&saradc {
> + status = "okay";
> +};
> +
> /* SD card */
> &sd_emmc_b {
> status = "okay";
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 3/3] arm64: dts: meson: add GPIO line names to ODROID N2/N2+
2021-03-29 16:12 ` [PATCH 3/3] arm64: dts: meson: add GPIO line names " Christian Hewitt
@ 2021-03-30 15:23 ` Neil Armstrong
2021-03-31 21:32 ` Kevin Hilman
1 sibling, 0 replies; 10+ messages in thread
From: Neil Armstrong @ 2021-03-30 15:23 UTC (permalink / raw)
To: Christian Hewitt, Rob Herring, Mark Rutland, Kevin Hilman,
devicetree, linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Hyeonki Hong
On 29/03/2021 18:12, Christian Hewitt wrote:
> From: Hyeonki Hong <hhk7734@gmail.com>
>
> Add GPIO line-name identifiers to the ODROID N2/N2+ common dtsi.
>
> Signed-off-by: Hyeonki Hong <hhk7734@gmail.com>
> ---
> .../dts/amlogic/meson-g12b-odroid-n2.dtsi | 45 +++++++++++++++++++
> 1 file changed, 45 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> index 139c12cf9f66..4489715fc4f3 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> @@ -446,6 +446,51 @@
> };
>
> &gpio {
> + gpio-line-names =
> + /* GPIOZ */
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "",
> + /* GPIOH */
> + "", "", "", "", "", "", "", "",
> + "",
> + /* BOOT */
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "",
> + /* GPIOC */
> + "", "", "", "", "", "", "", "",
> + /* GPIOA */
> + "PIN_44", /* GPIOA_0 */
> + "PIN_46", /* GPIOA_1 */
> + "PIN_45", /* GPIOA_2 */
> + "PIN_47", /* GPIOA_3 */
> + "PIN_26", /* GPIOA_4 */
> + "", "", "", "", "", "",
> + "PIN_42", /* GPIOA_11 */
> + "PIN_32", /* GPIOA_12 */
> + "PIN_7", /* GPIOA_13 */
> + "PIN_27", /* GPIOA_14 */
> + "PIN_28", /* GPIOA_15 */
> + /* GPIOX */
> + "PIN_16", /* GPIOX_0 */
> + "PIN_18", /* GPIOX_1 */
> + "PIN_22", /* GPIOX_2 */
> + "PIN_11", /* GPIOX_3 */
> + "PIN_13", /* GPIOX_4 */
> + "PIN_33", /* GPIOX_5 */
> + "PIN_35", /* GPIOX_6 */
> + "PIN_15", /* GPIOX_7 */
> + "PIN_19", /* GPIOX_8 */
> + "PIN_21", /* GPIOX_9 */
> + "PIN_24", /* GPIOX_10 */
> + "PIN_23", /* GPIOX_11 */
> + "PIN_8", /* GPIOX_12 */
> + "PIN_10", /* GPIOX_13 */
> + "PIN_29", /* GPIOX_14 */
> + "PIN_31", /* GPIOX_15 */
> + "PIN_12", /* GPIOX_16 */
> + "PIN_3", /* GPIOX_17 */
> + "PIN_5", /* GPIOX_18 */
> + "PIN_36"; /* GPIOX_19 */
> /*
> * WARNING: The USB Hub on the Odroid-N2 needs a reset signal
> * to be turned high in order to be detected by the USB Controller
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 3/3] arm64: dts: meson: add GPIO line names to ODROID N2/N2+
2021-03-29 16:12 ` [PATCH 3/3] arm64: dts: meson: add GPIO line names " Christian Hewitt
2021-03-30 15:23 ` Neil Armstrong
@ 2021-03-31 21:32 ` Kevin Hilman
1 sibling, 0 replies; 10+ messages in thread
From: Kevin Hilman @ 2021-03-31 21:32 UTC (permalink / raw)
To: Christian Hewitt, Rob Herring, Mark Rutland, devicetree,
linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Christian Hewitt, Hyeonki Hong
Hi Christian,
Christian Hewitt <christianshewitt@gmail.com> writes:
> From: Hyeonki Hong <hhk7734@gmail.com>
>
> Add GPIO line-name identifiers to the ODROID N2/N2+ common dtsi.
>
> Signed-off-by: Hyeonki Hong <hhk7734@gmail.com>
You need to add your SoB here also.
Kevin
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] arm64: dts: meson: remove extra tab from ODROID N2/N2+ ext_mdio node
2021-03-29 16:12 ` [PATCH 1/3] arm64: dts: meson: remove extra tab from ODROID N2/N2+ ext_mdio node Christian Hewitt
2021-03-30 15:22 ` Neil Armstrong
@ 2021-04-05 20:54 ` Martin Blumenstingl
1 sibling, 0 replies; 10+ messages in thread
From: Martin Blumenstingl @ 2021-04-05 20:54 UTC (permalink / raw)
To: Christian Hewitt
Cc: Rob Herring, Mark Rutland, Kevin Hilman, devicetree,
linux-arm-kernel, linux-amlogic, linux-kernel
On Tue, Mar 30, 2021 at 1:17 AM Christian Hewitt
<christianshewitt@gmail.com> wrote:
>
> Remove an extra tab from the ext_mdio node in the ODROID N2/N2+ common
> dtsi file.
>
> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/3] arm64: dts: meson: add saradc node to ODROID N2/N2+
2021-03-29 16:12 ` [PATCH 2/3] arm64: dts: meson: add saradc node to ODROID N2/N2+ Christian Hewitt
2021-03-30 15:23 ` Neil Armstrong
@ 2021-04-05 20:56 ` Martin Blumenstingl
1 sibling, 0 replies; 10+ messages in thread
From: Martin Blumenstingl @ 2021-04-05 20:56 UTC (permalink / raw)
To: Christian Hewitt
Cc: Rob Herring, Mark Rutland, Kevin Hilman, devicetree,
linux-arm-kernel, linux-amlogic, linux-kernel, Hyeonki Hong
On Tue, Mar 30, 2021 at 1:18 AM Christian Hewitt
<christianshewitt@gmail.com> wrote:
>
> From: Hyeonki Hong <hhk7734@gmail.com>
>
> Add the meson saradc node to the ODROID N2/N2+ common dtsi.
in general I am fine with this as some SAR ADC channels seem to be on
the pin headers...
[...]
> +&saradc {
> + status = "okay";
> +};
...but a vref-supply should be provided to get meaningful numbers
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-04-05 20:56 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-29 16:12 [PATCH 0/3] arm64: dts: meson: misc ODROID-N2/N2+ changes Christian Hewitt
2021-03-29 16:12 ` [PATCH 1/3] arm64: dts: meson: remove extra tab from ODROID N2/N2+ ext_mdio node Christian Hewitt
2021-03-30 15:22 ` Neil Armstrong
2021-04-05 20:54 ` Martin Blumenstingl
2021-03-29 16:12 ` [PATCH 2/3] arm64: dts: meson: add saradc node to ODROID N2/N2+ Christian Hewitt
2021-03-30 15:23 ` Neil Armstrong
2021-04-05 20:56 ` Martin Blumenstingl
2021-03-29 16:12 ` [PATCH 3/3] arm64: dts: meson: add GPIO line names " Christian Hewitt
2021-03-30 15:23 ` Neil Armstrong
2021-03-31 21:32 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).