From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A7E0C43460 for ; Mon, 5 Apr 2021 20:29:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E40A613CA for ; Mon, 5 Apr 2021 20:29:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240891AbhDEU3W (ORCPT ); Mon, 5 Apr 2021 16:29:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236422AbhDEU3L (ORCPT ); Mon, 5 Apr 2021 16:29:11 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 420CBC061788 for ; Mon, 5 Apr 2021 13:29:02 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id b8-20020a17090a5508b029014d0fbe9b64so2670516pji.5 for ; Mon, 05 Apr 2021 13:29:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ONE9SgRu2tAB0bKzuvFoPjlBosnX6JZfWs8NKXHvA4Q=; b=FfymRgM824j1zYBR0q6aKkMArv3x6ubHtrtPSsl9WewyXQ0FoXuCeszFRgOa6u/QEq 7r8mLzV8QfCds35XqsmCS9JmsEIrmRLqDQ8kvBmxFIYJ09h8ud1aiYtiIhwgDQRwFWyb guEXtqoWZNOrBMa49L6RkNZJKz1UAeHzTfQuQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ONE9SgRu2tAB0bKzuvFoPjlBosnX6JZfWs8NKXHvA4Q=; b=Gps87DLgcf7F/5kxnlLQVEjZT2N5XC8osXDL+z6gsz8hCK2Nl3S1BJ2KfCBFqhPNq8 ieWyeAbv07EZrViV/juMbs/nCoo7T/UH7tvqGOZz05s1/iW0x3vRYF3VDCR1yRNQKu+/ sFCCnQACe8AZJ9maJ+WnLMaGmWVVrV9eJoNJDDg15f2sO03r8UuG1XPeZJl3Kqu6wGBd Bz5YiJFNIyisAo+NW3XlfwClXz/UdtdZ+G1/L8sE15H/QycYIJc+0AobzPVuD9tKVTRr iRUagQYvJFinqHSFeb0vmcf7HuRsZjvLvaWR2bqPFbLSikxTNU/B45ec8+SNXH6e4ING /9kg== X-Gm-Message-State: AOAM5318qfMblAtsKVw8tgeq3DyLsxvahha0IEyqffp8tmwmuQ+9ddZ5 lmbElRDBf+fk3UsytXzYwd1hnGEOoVAcgg== X-Google-Smtp-Source: ABdhPJyGGY8DkT+f5kXmdRJ7zwVBTbVaoWRky8rP+wx7GbePeebTDoSqQ6aIjbnQlLUSfxp54eSLPQ== X-Received: by 2002:a17:902:e54c:b029:e5:e7cf:d746 with SMTP id n12-20020a170902e54cb02900e5e7cfd746mr25759673plf.56.1617654541797; Mon, 05 Apr 2021 13:29:01 -0700 (PDT) Received: from localhost ([2620:15c:202:201:2926:73d2:2f29:3222]) by smtp.gmail.com with UTF8SMTPSA id w15sm16035054pfn.84.2021.04.05.13.29.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Apr 2021 13:29:01 -0700 (PDT) From: Gwendal Grignou X-Google-Original-From: Gwendal Grignou To: bleung@chromium.org, enric.balletbo@collabora.com, groeck@chromium.org Cc: linux-kernel@vger.kernel.org, Gwendal Grignou , stable@vger.kernel.org Subject: [PATCH v2 1/2] platform/chrome: Use dev_groups to set device sysfs attributes Date: Mon, 5 Apr 2021 13:28:56 -0700 Message-Id: <20210405202857.1265308-2-gwendal@google.com> X-Mailer: git-send-email 2.31.0.208.g409f899ff0-goog In-Reply-To: <20210405202857.1265308-1-gwendal@google.com> References: <20210405202857.1265308-1-gwendal@google.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Instead of manually call sysfs_create_group()/sysfs_remove_group(), set .dev_groups driver data structure, and let the bus base code create sysfs attributes. Fixes: 6fd7f2bbd442 ("mfd / platform: cros_ec: Move device sysfs attributes to its own driver") Cc: stable@vger.kernel.org Signed-off-by: Gwendal Grignou --- New in v2. drivers/platform/chrome/cros_ec_sysfs.c | 28 +++++-------------------- 1 file changed, 5 insertions(+), 23 deletions(-) diff --git a/drivers/platform/chrome/cros_ec_sysfs.c b/drivers/platform/chrome/cros_ec_sysfs.c index f07eabcf9494c..114b9dbe981e7 100644 --- a/drivers/platform/chrome/cros_ec_sysfs.c +++ b/drivers/platform/chrome/cros_ec_sysfs.c @@ -335,34 +335,16 @@ static const struct attribute_group cros_ec_attr_group = { .is_visible = cros_ec_ctrl_visible, }; -static int cros_ec_sysfs_probe(struct platform_device *pd) -{ - struct cros_ec_dev *ec_dev = dev_get_drvdata(pd->dev.parent); - struct device *dev = &pd->dev; - int ret; - - ret = sysfs_create_group(&ec_dev->class_dev.kobj, &cros_ec_attr_group); - if (ret < 0) - dev_err(dev, "failed to create attributes. err=%d\n", ret); - - return ret; -} - -static int cros_ec_sysfs_remove(struct platform_device *pd) -{ - struct cros_ec_dev *ec_dev = dev_get_drvdata(pd->dev.parent); - - sysfs_remove_group(&ec_dev->class_dev.kobj, &cros_ec_attr_group); - - return 0; -} +static const struct attribute_group *cros_ec_attr_groups[] = { + &cros_ec_attr_group, + NULL, +}; static struct platform_driver cros_ec_sysfs_driver = { .driver = { .name = DRV_NAME, + .dev_groups = cros_ec_attr_groups, }, - .probe = cros_ec_sysfs_probe, - .remove = cros_ec_sysfs_remove, }; module_platform_driver(cros_ec_sysfs_driver); -- 2.31.0.208.g409f899ff0-goog