From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28E61C43460 for ; Tue, 6 Apr 2021 14:13:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF89461382 for ; Tue, 6 Apr 2021 14:13:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344915AbhDFONj (ORCPT ); Tue, 6 Apr 2021 10:13:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344891AbhDFONZ (ORCPT ); Tue, 6 Apr 2021 10:13:25 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF99FC06174A; Tue, 6 Apr 2021 07:13:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=pZwMcf5iEm9vQedhznNSrB1eoBlpxK0vTkFxcd3+VS4=; b=fCLis4aRjdezyDv5mCGo2tcDKb /AR6CsS8iGBK+ThwUJMuULlVAdDQeN+Rmlex9MFGZisePOqgXNQc75EAcPGIrjJBLtp+JgHU7uY2B 2emgSSuq+jO6ayyxTR85dlGVBsWYGiw7GGtEcZHtZMhMVSlG6oc47q4iVx/orrKOTHVwXApxp25z3 SsBTeJkKze3KLs5dfdAJ0SM58KVMz2trc2ExJhm/OMdoqxgWfP7oGHKdvJMkgeat/ID0uyHa0qB5j BYo2KlA3pI3KSXUxBX0dl1BwiVWQ/blR2F9+joYd/hnqH37P27I0WFubF503vmc6Tgk+H6/kAaLXl r/dvou2Q==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lTmQp-00Cukf-Ls; Tue, 06 Apr 2021 14:12:11 +0000 Date: Tue, 6 Apr 2021 15:11:51 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, linux-afs@lists.infradead.org Subject: Re: [PATCH v6 21/27] mm/filemap: Add wait_on_folio_locked Message-ID: <20210406141151.GT3062550@infradead.org> References: <20210331184728.1188084-1-willy@infradead.org> <20210331184728.1188084-22-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210331184728.1188084-22-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 31, 2021 at 07:47:22PM +0100, Matthew Wilcox (Oracle) wrote: > Also add wait_on_folio_locked_killable(). Turn wait_on_page_locked() > and wait_on_page_locked_killable() into wrappers. This eliminates a > call to compound_head() from each call-site, reducing text size by 200 > bytes for me. > > Signed-off-by: Matthew Wilcox (Oracle) Looks good, Reviewed-by: Christoph Hellwig