From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E83BC433ED for ; Wed, 14 Apr 2021 18:13:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1D10061179 for ; Wed, 14 Apr 2021 18:13:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352547AbhDNSNX (ORCPT ); Wed, 14 Apr 2021 14:13:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351623AbhDNSMU (ORCPT ); Wed, 14 Apr 2021 14:12:20 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE72CC06175F for ; Wed, 14 Apr 2021 11:11:56 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id g17so24106748edm.6 for ; Wed, 14 Apr 2021 11:11:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=y1xEJfVPK/KJcyn6yk0NvIQoWVbimOipuoswkuSyxmY=; b=R6J1yskmrnGQpY1neW/kEEUuOTWsef3Ud7PkyUOZbMXEa3lakTG9PI5NePTz2Vlk5M 8TTsIaIOUQY6u4Yiz45Q/0pfw/bqE4LGVIoc41BvuKqvUBRUxP3CwoIj9EhYXTPFsBe7 DrqvtdW/EpoU/pfq4XNTvK4gKJn/pujQeiTV6JXqCIhKQqj+z05QYBe/+lFpGUGJHlvn +cg0Ff7nrrcCA3WoSU/1y0lBEHJV91404kTJ62nOLe+Iqz0bwDL2k9adLuesbcJ7sY8b 4nuUUFKBsM7Tf0vp+o5x5D9sxOSZHNIbdvmdbEKI7MHzTX5Io+1iLEGbR0FIvGo2qQK+ hDxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=y1xEJfVPK/KJcyn6yk0NvIQoWVbimOipuoswkuSyxmY=; b=DmP2SYP00vPlupWesNZwbrQO57CoG0z5Z3vjmmRfS32t42qzxavEZ+DYvwyxNgjKvF 1tJksWovoIiX6iYfDsY9uc3qtxJG6MynuAlgJtMa3E5ff/YRo3I7yDAXzuT2XdADFSw4 SoyBSDlI8M5EJoOv+tI6jLRr4y0+2MxfNY8PCGny//umURXjTfQAiULpNGR5cHHASGim S842h3Urtwr8uVG2nmJrMQplNd+1GNara5bvBTBUSuK2AgpiOjUij3sxurvWwtNQvMbS iE1Z/QPQjDY91dZioFS5HO6vmKJhtuqSUhPe4eVw+WD1qcdYKU//lcB59fq7HIr8bdAL ILFg== X-Gm-Message-State: AOAM532BlLiJNkhV2BjpBDiJf7nD6zft6jSUksaE8Wi3RtJxkXv85m50 9lRBC8ejWRsjMALpEj4Xnlje4Q== X-Google-Smtp-Source: ABdhPJzGmm9NN5vcyCvxsT7nJqdnxo4NTz5CHnbER1eUkJU8WR8j6Cvho4PPzgItkyxumLFrpL9nMQ== X-Received: by 2002:a05:6402:254f:: with SMTP id l15mr162513edb.189.1618423915476; Wed, 14 Apr 2021 11:11:55 -0700 (PDT) Received: from dell.default ([91.110.221.215]) by smtp.gmail.com with ESMTPSA id v1sm279493eds.17.2021.04.14.11.11.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Apr 2021 11:11:54 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Zhansaya Bagdauletkyzy , Michael Straube , WLAN FAE , linux-staging@lists.linux.dev Subject: [PATCH 20/57] staging: rtl8712: rtl871x_mp_ioctl: Move a large data struct onto the heap Date: Wed, 14 Apr 2021 19:10:52 +0100 Message-Id: <20210414181129.1628598-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210414181129.1628598-1-lee.jones@linaro.org> References: <20210414181129.1628598-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/staging/rtl8712/rtl871x_mp_ioctl.c: In function ‘mp_start_test’: drivers/staging/rtl8712/rtl871x_mp_ioctl.c:204:1: warning: the frame size of 1136 bytes is larger than 1024 bytes [-Wframe-larger-than=] Cc: Larry Finger Cc: Florian Schilhabel Cc: Greg Kroah-Hartman Cc: Zhansaya Bagdauletkyzy Cc: Michael Straube Cc: WLAN FAE Cc: linux-staging@lists.linux.dev Signed-off-by: Lee Jones --- drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 29 +++++++++++++--------- 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_mp_ioctl.c b/drivers/staging/rtl8712/rtl871x_mp_ioctl.c index 31414a960c9ed..adbeb46770d7a 100644 --- a/drivers/staging/rtl8712/rtl871x_mp_ioctl.c +++ b/drivers/staging/rtl8712/rtl871x_mp_ioctl.c @@ -149,26 +149,30 @@ static int mp_start_test(struct _adapter *padapter) struct mp_priv *pmppriv = &padapter->mppriv; struct mlme_priv *pmlmepriv = &padapter->mlmepriv; struct wlan_network *tgt_network = &pmlmepriv->cur_network; - struct wlan_bssid_ex bssid; + struct wlan_bssid_ex *bssid; struct sta_info *psta; unsigned long length; unsigned long irqL; int res = 0; + bssid = kzalloc(sizeof(*bssid), GFP_KERNEL); + if (!bssid) + return -ENOMEM; + /* 3 1. initialize a new struct wlan_bssid_ex */ - memcpy(bssid.MacAddress, pmppriv->network_macaddr, ETH_ALEN); - bssid.Ssid.SsidLength = 16; - memcpy(bssid.Ssid.Ssid, (unsigned char *)"mp_pseudo_adhoc", - bssid.Ssid.SsidLength); - bssid.InfrastructureMode = Ndis802_11IBSS; - bssid.NetworkTypeInUse = Ndis802_11DS; - bssid.IELength = 0; - length = r8712_get_wlan_bssid_ex_sz(&bssid); + memcpy(bssid->MacAddress, pmppriv->network_macaddr, ETH_ALEN); + bssid->Ssid.SsidLength = 16; + memcpy(bssid->Ssid.Ssid, (unsigned char *)"mp_pseudo_adhoc", + bssid->Ssid.SsidLength); + bssid->InfrastructureMode = Ndis802_11IBSS; + bssid->NetworkTypeInUse = Ndis802_11DS; + bssid->IELength = 0; + length = r8712_get_wlan_bssid_ex_sz(bssid); if (length % 4) { /*round up to multiple of 4 bytes.*/ - bssid.Length = ((length >> 2) + 1) << 2; + bssid->Length = ((length >> 2) + 1) << 2; } else { - bssid.Length = length; + bssid->Length = length; } spin_lock_irqsave(&pmlmepriv->lock, irqL); if (check_fwstate(pmlmepriv, WIFI_MP_STATE)) @@ -185,7 +189,7 @@ static int mp_start_test(struct _adapter *padapter) tgt_network->network.MacAddress); if (psta) r8712_free_stainfo(padapter, psta); - psta = r8712_alloc_stainfo(&padapter->stapriv, bssid.MacAddress); + psta = r8712_alloc_stainfo(&padapter->stapriv, bssid->MacAddress); if (!psta) { res = -ENOMEM; goto end_of_mp_start_test; @@ -200,6 +204,7 @@ static int mp_start_test(struct _adapter *padapter) set_fwstate(pmlmepriv, _FW_LINKED); end_of_mp_start_test: spin_unlock_irqrestore(&pmlmepriv->lock, irqL); + kfree(bssid); return res; } -- 2.27.0