From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA2BBC433ED for ; Wed, 12 May 2021 18:31:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B09FE6143A for ; Wed, 12 May 2021 18:31:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355394AbhELS2P (ORCPT ); Wed, 12 May 2021 14:28:15 -0400 Received: from foss.arm.com ([217.140.110.172]:44186 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242516AbhELQe7 (ORCPT ); Wed, 12 May 2021 12:34:59 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0A5891FB; Wed, 12 May 2021 09:33:51 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.72.67]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D5D903F719; Wed, 12 May 2021 09:33:41 -0700 (PDT) Date: Wed, 12 May 2021 17:33:37 +0100 From: Mark Rutland To: Greg Ungerer Cc: Geert Uytterhoeven , Linux Kernel Mailing List , Will Deacon , Boqun Feng , Peter Zijlstra , Albert Ou , Arnd Bergmann , Brian Cain , Benjamin Herrenschmidt , Chris Zankel , Rich Felker , "David S. Miller" , Vincent Chen , Helge Deller , Greentime Hu , Guo Ren , Ivan Kokshaysky , James Bottomley , Max Filippov , Jonas Bonn , Ley Foon Tan , Russell King , Matt Turner , Michal Simek , Michael Ellerman , Nick Hu , Palmer Dabbelt , Paul Mackerras , Paul Walmsley , Richard Henderson , Stafford Horne , Stefan Kristiansson , Thomas Bogendoerfer , Vineet Gupta , Yoshinori Sato Subject: Re: [PATCH 20/33] locking/atomic: m68k: move to ARCH_ATOMIC Message-ID: <20210512163337.GB97719@C02TD0UTHF1T.local> References: <20210510093753.40683-1-mark.rutland@arm.com> <20210510093753.40683-21-mark.rutland@arm.com> <20210511100022.GD6152@C02TD0UTHF1T.local> <2501f556-1326-f09c-baa2-464057ea100c@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2501f556-1326-f09c-baa2-464057ea100c@linux-m68k.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 13, 2021 at 12:15:58AM +1000, Greg Ungerer wrote: > On 11/5/21 8:27 pm, Geert Uytterhoeven wrote: > > On Tue, May 11, 2021 at 12:00 PM Mark Rutland wrote: > > > On Tue, May 11, 2021 at 11:27:45AM +0200, Geert Uytterhoeven wrote: > > > > On Mon, May 10, 2021 at 11:42 AM Mark Rutland wrote: > > > > > We'd like all architectures to convert to ARCH_ATOMIC, as once all > > > > > architectures are converted it will be possible to make significant > > > > > cleanups to the atomics headers, and this will make it much easier to > > > > > generically enable atomic functionality (e.g. debug logic in the > > > > > instrumented wrappers). > > > > > > > > > > As a step towards that, this patch migrates m68k to ARCH_ATOMIC. The > > > > > arch code provides arch_{atomic,atomic64,xchg,cmpxchg}*(), and common > > > > > code wraps these with optional instrumentation to provide the regular > > > > > functions. > > > > > > > > > > Signed-off-by: Mark Rutland > > > > > > > > Reviewed-by: Geert Uytterhoeven > > > > Acked-by: Geert Uytterhoeven > > > > > > > > I even gave this series a spin on ARAnyM and QEMU, and everything > > > > seems to be fine. > > > > > > Thanks! That's much appreciated; I was able to build-test, but didn't > > > have a suitable setup for boot testing. > > > > > > The Kbuild test robot noticed I broke one configuration by renaming > > > atomic_dec_and_test_lt(), since it's not part of the common atomic API, > > > and is used in get_mmu_context() in . > > > > Ah, that's in the part for Coldfire, so I (and my builds) didn't notice. > > > > > On the primciple of keeping the common atomic API separate from > > > arch-specific bits, I've kept the `arch_` prefix and updated the caller. > > > Does that sound good to you? > > > > That's fine for me, but as this is Coldfire, I'd like to defer to Greg. > > Looks fine to me too. > > Acked-by: Greg Ungerer Thanks! Mark.